[Bugfix][Blackwell] Avoid fmha_bwd workspace int32 overflow - #3614
Open
XFDG wants to merge 1 commit into
Open
Conversation
Signed-off-by: zhaoye <yzhao04@iquestlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlackwellFusedMultiHeadAttentionBackward._get_workspace_sizecombines user-shape parameters for workspace sizing with integer math that can be narrowed to int32 in the Cute/CUDA path for large sequence and batch dimensions. That can truncate the size and trigger allocation-related failures.Fix
In
examples/python/CuTeDSL/cute/blackwell/kernel/attention/fmha/fmha_bwd.pyfunctionBlackwellFusedMultiHeadAttentionBackward._get_workspace_size, explicitly use Pythonintintermediates for all multipliers and dimensions:q/dwithint((q + 7) // 8 * 8)b_i32,h_i32,q_i32,d_i32, andacc_bytesOverflowErrorif computed workspace bytes is negativeThis keeps workspace arithmetic in Python big-int space and avoids unintentional int32 narrowing before CUDA allocation.
Testing
python3 - <<'PY' seq_len = 46341 ws = int(seq_len) * int(seq_len) * 4 assert ws > 0 print('workspace size:', ws) PYFixes #2886