Structured YAML unmarshalling based manifest kind detection - #2779
Merged
tariq1890 merged 2 commits intoAug 21, 2026
Conversation
kvalliyurnatt
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
August 21, 2026 14:34
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
kvalliyurnatt
force-pushed
the
modify_kind_detection_state_manager
branch
from
August 21, 2026 14:37
868f92f to
f0dc45f
Compare
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
tariq1890
approved these changes
Aug 21, 2026
tariq1890
left a comment
tariq1890
left a comment
Contributor
There was a problem hiding this comment.
Thank you @kvalliyurnatt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Regex based Kubernetes manifest kind detection with structured YAML unmarshalling. This feels a little more safe than regex based yaml parsing. Also added a couple of unit tests to test this.