fix(ratelimiter): log metrics server bind failures at error level - #1096
Draft
rootkiller6788 wants to merge 1 commit into
Draft
fix(ratelimiter): log metrics server bind failures at error level#1096rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
setupMetrics discards the http.ListenAndServe error in an empty branch, so a Prometheus listener that fails to bind leaves the service running with no metrics and no signal in the pod logs. Log the failure at error level, matching setupPprof and setupOlricStats in the same file. Add a regression test that occupies the metrics port so the bind fails deterministically, and asserts the error-level log line is emitted.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setupMetricsinsrc/invocation-plane-services/ratelimiter/cmd/main.godiscarded thehttp.ListenAndServeerror in an empty branch:If the Prometheus listener cannot bind, the service keeps running with no metrics and logs nothing — scrapes fail with connection refused and there is no signal in the pod logs. This fixes #540.
Change
setupPprofandsetupOlricStatsservers in the same file.metrics_test.go: a regression test that occupies0.0.0.0:7776so the bind fails deterministically, swaps the global logger for azaptest/observer, and asserts themetrics server failedlog line is emitted.metrics_test.gointo thecmd_testbazel target.Verification
go build ./cmd/...passes.go vet ./cmd/passes.go test ./cmd/ -run TestSetupMetricsLogsServeFailure -count=1passes.The empty branch is the only code path the fix touches; the error log uses the same
zap.L().Error(...)idiom already used by the other two servers in the file.