add missing inplace_stop_callback::callback_type - #2290
Merged
Merged
Conversation
[stopcallback.inplace.general] declares `using callback_type = CallbackFn;` as a public member of `inplace_stop_callback`. stdexec did not provide it, so `inplace_stop_callback<F>::callback_type` failed to compile. Add the alias and a test.
ericniebler
approved these changes
Sep 28, 2026
Collaborator
|
/ok to test 95f800d |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard declares a public member type alias in
inplace_stop_callback(stopcallback.inplace.general):using callback_type = CallbackFn;stdexec did not declare it, so
inplace_stop_callback<F>::callback_typefailed to compile (MSVC: "error C2039: 'callback_type': is not a member of 'std::inplace_stop_callback<...>'").This adds the alias at the top of the class, plus a test in
test_concepts_stop_tokens.cppthat checks it names the callback type.Tested locally with MSVC 14.44 (Debug): the new test fails to compile without the fix and passes with it, and the rest of
test.stdexecpasses too (test_any.cppwas left out of the local build because this MSVC version hits an internal compiler error on it, on main as well). clang-format 21 reports no changes on the touched files.