magic :: code clean up and documentation - #1524
Conversation
| BELONG("BELONG", 6, 4), | ||
|
|
||
| /** A 4-byte big-endian date stamp, skipped by the parser. */ | ||
| BEDATE("BEDATE", 7, 4), |
There was a problem hiding this comment.
With this change BEDATE becomes a supported type right? Just double checking
main: '0 bedate 0x41424344 FOO' -> ParseException: Unsupported Data Type: bedate
1424: '0 bedate 0x41424344 FOO' -> OK: 0 BEDATE =0x41424344 FOO
There was a problem hiding this comment.
No, this change is just moving some things around and attempting to start code clean up. All behavior should be as before. Follow on changes will actually add support for more types. These types were moved to this enum from MagicNumber.
There was a problem hiding this comment.
@cfkoehler Instead of this code cleanup pr, maybe I should add more testing first to exercise what's there? That way we can sift thru what's implemented fully and what errors out. This can serve as a follow on pr to that. Thoughts?
There was a problem hiding this comment.
making note of the protected -> private scope changes. Not sure the impact of that downstream.
This update continues modernizing our magic file processing logic, focusing on code cleanup, immutability, and documentation. Key improvements include: