kicad.base: remove unused dependencies - #563947
Merged
Merged
Conversation
Removing all of these dependencies changes nothing about the output derivation, so it seems to be fine. Saves quite a bit of building before on stdenv rebuilds which is nice, but also just cleans up dep trees
nixpkgs-ci
Bot
added
the
2.status: merge-bot eligible
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
LordGrimmauld
approved these changes
Sep 16, 2026
LordGrimmauld
left a comment
LordGrimmauld
left a comment
Contributor
There was a problem hiding this comment.
+1 after looking through the diffoscope output
nixpkgs-ci
Bot
added
the
12.approvals: 1
korken89
approved these changes
Sep 16, 2026
korken89
left a comment
korken89
left a comment
Contributor
There was a problem hiding this comment.
Tested, seems to work equivalently to before 👍
nixpkgs-ci
Bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing all of these dependencies changes nothing about the output derivation, so it seems to be fine. Saves quite a bit of building before on stdenv rebuilds which is nice, but also just cleans up dep trees.
I'm not a kicad user, but it started fine and was able to open some blank files. No idea how to further test it.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.