Conversation
13 tasks
dtomvan
reviewed
Sep 16, 2026
Contributor
|
Code looks good, just would like to see this tested in an actual configuration. Just don't have the time right now... sorry for that. |
pyrox0
reviewed
Sep 16, 2026
samiser
force-pushed
the
noctalia-greeter-passwordless-sync
branch
from
September 16, 2026 22:07
e83aeba to
79b249f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add passwordless sync support for noctalia-greeter, mostly taking the nix from upstream where possible.
Tested by eval, the rules file generates correctly and the pkexec wrapper is enabled.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.