Add NamedRoutes support to nri-test-encoding - #137
Merged
Conversation
Member
|
LGTM. Do you want to open a PR in our main repo pointing to this version? So we can verify that it can pass CI before merging. |
Member
Author
|
Based on a local branch the code should work. The lower bound versions I got them from monorepo dev environment. The code is not yet used, but i can check things will build with the version bump if that is where the uncertainty is coming. |
waj
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumps min servant version to match the currently used one. This avoids the need for conditional compilation.