Fix space leak in nri-observability - #141
Merged
Merged
Conversation
brian-carroll
approved these changes
Sep 23, 2025
brian-carroll
left a comment
Contributor
There was a problem hiding this comment.
Excellent! Great detective work! 🕵️ 🔍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #134 was deployed to prod, NRI's highest traffic service started slowly increasing memory usage over time, at a rate of around 5MiB/min.
This PR introduces a test app that reproduces the memory leak, and a fix.
The issue was elusive:
-hmpointed fingers atData.Conduit.Internal-fno-full-lazinessdidn't help-K1Kdidn't make my leaky test app blow up-hyshowed anIntwas leaking, and Waj's PR did introduce an Int inside theSTMin the handlerI was still suspicious of
Conduit, so while googling forconduit stm space leakI landed on thestrict-stmlibrary, which claimed to have helped makecardano-nodeleak-free.The library was a drop-in replacement for
stm, and using it made our leak go away.