Skip to content

Add latest SUNDIALS version to local Spack repos. - #584

Merged
nkoukpaizan merged 1 commit into
steven/sundials-upgradesfrom
nicholson/sundials-upgrades
Sep 17, 2026
Merged

nkoukpaizan merged 1 commit into
steven/sundials-upgradesfrom
nicholson/sundials-upgrades

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Description

This adds a local Spack package repo for SUNDIALS that extends the builtin package with version 7.8.0 and 7.9.0. These are in spack-packages/develop, but not yet in a release.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

We more generally need to upgrade the Spack version we are using, but this is out of scope for this PR.

@nkoukpaizan nkoukpaizan self-assigned this Sep 17, 2026
@nkoukpaizan nkoukpaizan added the development Features/Tools related to development of GridKit, rather than use as a library. label Sep 17, 2026
@nkoukpaizan
nkoukpaizan marked this pull request as ready for review September 17, 2026 18:32
@nkoukpaizan
nkoukpaizan merged commit df36669 into steven/sundials-upgrades Sep 17, 2026
6 checks passed
pelesh pushed a commit that referenced this pull request Sep 17, 2026
* Update SUNDIALS version

* Add max order option to IDA and PhasorDynamics apps

* Fix abs tol for fixed time steps

* Add exception handling to ensure SUNDIALS logs are written properly on error

* Update changelog

* Apply pre-commit fixes

* Add latest SUNDIALS version to local Spack repos. (#584)

---------

Co-authored-by: Steven-Roberts <Steven-Roberts@users.noreply.github.com>
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Features/Tools related to development of GridKit, rather than use as a library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants