Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the OSD module version to 26.8.5.1 and documents a broad internal refactor: core OS catalog parsing is centralized, driver pack lookup is renamed/repointed, and cache/device helper functions are moved into dedicated private scripts while generated help/docs are refreshed.
Changes:
- Centralized OS catalog import/normalization via new
Get-ModuleCoreOperatingSystemsand updatedGet-OSDCoreOperatingSystemsconsumers. - Renamed driver pack helper to
Get-ModuleCoreDriverPacksand updated CLI/GUI/device workflows to call it. - Split cache/USB/cache-drive helpers into dedicated private functions, removed legacy in-file implementations, and regenerated help/docs + updated
CHANGELOG.md.
Reviewed changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Public/core-recast/Start-RecastOSDCloudCLI.ps1 | Switches manufacturer override driver-pack lookup to Get-ModuleCoreDriverPacks. |
| Private/core-operatingsystem/Set-OSDCoreOperatingSystemCloudObject.ps1 | Expands comment-based help (examples/inputs/outputs) and notes entry. |
| Private/core-operatingsystem/Get-OSDCoreOperatingSystems.ps1 | Refactors OS catalog ingestion to use Get-ModuleCoreOperatingSystems and refreshes help content. |
| Private/core-operatingsystem/Get-OSDCloudCoreOperatingSystems.ps1 | Adds new OSDCloud OS record normalization helper (with comment-based help). |
| Private/core-operatingsystem/Get-ModuleCoreOperatingSystems.ps1 | Adds new normalized raw OS catalog importer from module XML cache. |
| Private/core-operatingsystem/dev/Get-OSDCloudDefaultOS.ps1 | Updates default-OS selection help text and keeps using OSDCloud OS records. |
| Private/core-driverpack/Get-ModuleCoreDriverPacks.ps1 | Renames driver-pack helper and updates examples to new function name. |
| Private/core-device/Update-RecastOSDCloudUSBCache.ps1 | Updates driver-pack lookup to use Get-ModuleCoreDriverPacks. |
| Private/core-device/Test-OSDCoreCacheUSB.ps1 | Adds a new USB-cache-drive presence test helper. |
| Private/core-device/Sync-OSDCoreDateTime.ps1 | Adds a new internet-time-based WinPE time sync helper. |
| Private/core-device/Initialize-OSDCoreDevice.ps1 | Updates driver-pack lookup to use Get-ModuleCoreDriverPacks. |
| Private/core-device/Get-OSDCoreCacheUSBPath.ps1 | Adds new helper to return OSDCloud cache paths on USB with free-space and FS filters. |
| Private/core-device/Get-OSDCoreCacheDrive.ps1 | Adds new helper to enumerate cache drives and USB metadata. |
| Private/core-device/Get-OSDCoreCacheContent.ps1 | Removes embedded cache/USB helper function definitions (moved to dedicated files). |
| Private/core-dev/Start-RecastOSDCloudGUI.ps1 | Switches manufacturer override driver-pack lookup to Get-ModuleCoreDriverPacks. |
| OSD.psd1 | Bumps module version, expands description, and edits FunctionsToExport list. |
| en-US/OSD-help.xml | Regenerates/updates compiled help content to reflect refactor/export changes. |
| docs/Update-RecastOSDCloudUSBCache.md | Removes generated markdown help for the migrated/internalized command. |
| docs/Test-OSDCoreCacheUSB.md | Removes generated markdown help for the migrated/internalized command. |
| docs/Initialize-OSDCoreDevice.md | Removes generated markdown help for the migrated/internalized command. |
| docs/Get-OSDCoreOperatingSystems.md | Updates generated markdown help text/examples to match revised function help. |
| docs/Get-OSDCoreDriverPacks.md | Removes generated markdown help for the renamed/migrated driver-pack helper. |
| docs/Get-OSDCoreDriverPackCatalogSurface.md | Removes generated markdown help for internalized Surface catalog helper. |
| docs/Get-OSDCoreDriverPackCatalogPanasonic.md | Removes generated markdown help for internalized Panasonic catalog helper. |
| docs/Get-OSDCoreDriverPackCatalogLenovo.md | Removes generated markdown help for internalized Lenovo catalog helper. |
| docs/Get-OSDCoreDriverPackCatalogHP.md | Removes generated markdown help for internalized HP catalog helper. |
| docs/Get-OSDCoreDriverPackCatalogDell.md | Removes generated markdown help for internalized Dell catalog helper. |
| docs/Get-OSDCoreCacheUSBPath.md | Removes generated markdown help for migrated cache USB path helper. |
| docs/Get-OSDCoreCacheDrive.md | Removes generated markdown help for migrated cache drive helper. |
| docs/Get-OSDCoreCacheContent.md | Removes generated markdown help for migrated cache content helper. |
| CHANGELOG.md | Replaces “Unreleased” with a 26.8.5.1 entry describing the refactor, version bump, and docs/help updates. |
Suppressed comments (2)
Private/core-operatingsystem/dev/Get-OSDCloudDefaultOS.ps1:49
- The help metadata doesn’t follow the module’s canonical comment-based help requirements: the first
.LINKshould behttps://github.com/OSDeploy/OSD/tree/master/docs, and.NOTESshould includeAuthor: David Segura - Recast Softwareplus a dated changelog entry.
Private/core-driverpack/Get-ModuleCoreDriverPacks.ps1:29 - The updated function name/examples are good, but the comment-based help block is now out of sync with the function signature and the module’s canonical help format: it doesn’t document
GenericDriverPackJson,.OUTPUTSshould reflect an array, and it’s missing the required.LINKand.NOTES(Author + YYYY-MM-DD changelog entry).
Comment on lines
+36
to
+41
| .LINK | ||
| https://www.osdeploy.com/ | ||
|
|
||
| .NOTES | ||
| Author: OSDeploy | ||
| 2026-08-05 - Standardized and expanded comment-based help |
Comment on lines
+19
to
+20
| - **Module manifest metadata refresh** (`OSD.psd1`) — Bumped module version to `26.8.5.1` and replaced the module description with a multi-line summary that references `recastsoftware.com`. | ||
| - **Export surface cleanup** (`OSD.psd1`) — Removed direct exports for cache, device, driver pack catalog, and USB cache update commands that were migrated to internal/private implementations. |
Comment on lines
+11
to
12
| ModuleVersion = '26.8.5.1' | ||
| CompatiblePSEditions = @('Core', 'Desktop') |
Comment on lines
36
to
40
| 'Show-OSDCoreLicenseHelp', | ||
| # RecastOSDCloud | ||
| 'Start-RecastOSDCloudCLI', | ||
| 'Update-RecastOSDCloudUSBCache', | ||
| # OSDCoreCache | ||
| 'Get-OSDCoreCacheContent', | ||
| 'Get-OSDCoreCacheDrive', | ||
| 'Get-OSDCoreCacheUSBPath', | ||
| 'Test-OSDCoreCacheUSB', | ||
| # OSDCoreDevice | ||
| 'Initialize-OSDCoreDevice', | ||
| 'Get-OSDCoreDeploymentDisk', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation