fix: poll Go usage with undici to bypass VS Code's global fetch patch - #133
Merged
Merged
Conversation
VS Code patches globalThis.fetch to route through the local http.proxy
setting, so in Remote-SSH sessions with a local proxy the usage polling
failed 100% of the time ("fetch failed") while model requests kept
working - provider.ts already uses undici.fetch and is not affected.
Switch goUsage.ts to the same approach and log err.cause so the real
network error (e.g. ECONNREFUSED) is visible in the logs (#98).
Fixes #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Go usage polling failed 100% of the time in Remote-SSH sessions when the local machine had
http.proxyset (#98): VS Code patches the extension host's globalfetchto route throughhttp.proxy, and on the remote host127.0.0.1:7890doesn't exist → instantECONNREFUSED→"fetch failed", status bar stuck atGo --. Chat requests were unaffected becauseprovider.tsusesundici.fetch. The log line also hid the real cause.Fix (src/goUsage.ts)
provider.ts's_createFetchWithTimeout(with the same fallback to global fetch when undici is unavailable). Immune to the proxy patch; consistent with model requests.err.causeongoUsage.fetch.failedsoECONNREFUSED& co. are visible.Verification
npm testgreen,tsccompiles.http.noProxyworkaround keeps working as an alternative.Fixes #98