Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_waters()returnedself._N, whichmove()maintains for the volume it samples, and cleared_is_bulkto mark the cache valid. Nothing invalidated t when positions changed, so a later call could report a count belonging to earlier positions, and the flag it cleared also records the move type.Give the reported count its own attribute, recount whenever there is a context to count from, and leave
_is_bulktomove(). Return the box count directly when no region is defined, which previously reached the region recount and failed on the reference indices it never set.Also adds a missing test file for #31.