Fix issues with multi-molecule REST2 selections - #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes OpenBioSim/somd2#197 by fixing issues with multi-molecule REST2 selections, where the masking logic failed due to
to_list()not being available on the selector container. The PR also makes a few performance tweaks and hardens the REST2 unit tests to include all types of additive and narrowing selection semantics.The PR also makes a small tweak to the previous PR, i.e. removing a kwarg from the generic
.to()convert method.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]