-
Notifications
You must be signed in to change notification settings - Fork 56
Epic: execution improvements #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
atravitz
wants to merge
11
commits into
main
Choose a base branch
from
epic/execution_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4ab9e20
epic: add warehouse (#1864)
atravitz 3897efc
feat: filesystem exorcist worker (#1833)
ethanholz d073f35
updates to filesystem warehouse worker-based execution (#2153)
atravitz 39301f0
filesystem warehouse usability improvements (#2155)
atravitz cda4e0a
add exorcist status check cli command (#2156)
atravitz 5e80eb5
update cli sections (#2171)
atravitz 2b4be37
move Worker to its own module (#2172)
atravitz 9d41033
add results handling for new worker-based execution (#2114)
atravitz bfe0308
CLI: support worker-based execution (#2174)
atravitz 477c65f
openfe status: add summary table (#2201)
atravitz 352ad4f
use conda-forge exorcist (#2209)
atravitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| .. _userguide_task_based_execution: | ||
|
|
||
| Task-based Execution | ||
| ==================== | ||
|
|
||
| In contrast to :ref:`quickrun execution <userguide_quickrun>`, task-based execution does not require that you explicitly define the Transformation to be executed. | ||
|
|
||
| This means that you can execute an entire ``AlchemicalNetwork``'s campaign just by calling the ``openfe run-task`` command iteratively until all tasks are complete! | ||
|
|
||
| .. include that ``task`` == ProtocolUnit, or is that confusing to non-dev users? | ||
|
|
||
| See below for details on how to run an openfe campaign using task-based execution using either the CLI or the Python API. | ||
|
|
||
| Task-based Execution with the CLI | ||
| --------------------------------- | ||
|
|
||
| Setting up a Campaign | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| An ``AlchemicalNetwork`` will be our input for executing a campaign. | ||
| Refer to the cookbook `Create an AlchemicalNetwork <../../cookbook/create_alchemical_network.nblink>`_ for guidance on getting to this step. | ||
|
|
||
| If you are accustomed to using the existing ``openfe plan-rbfe-network`` or ``openfe plan-rhfe-network`` CLI commands to create, you can simply add the ``--networks-only`` argument to your existing call, and use the resulting ``alchemicalNetwork.json`` as a starting point. | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe plan-rbfe-network --networks-only | ||
|
|
||
|
|
||
| Once you have an AlchemicalNetwork, use the following command to set up the task-based campaign. | ||
| By default, the ``TaskDB`` and ``Warehouse`` will be created using the input file basename (here, ``tyk2``). | ||
|
|
||
| .. TODO: The ``--name`` parameter lets us choose an identifier for the ``Warehouse`` and ``TaskDB`` file names. | ||
|
|
||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe setup-task-campaign --alchemical-network tyk2.json | ||
|
|
||
|
|
||
| You should see a ``Warehouse`` in the form of a directory and a ``TaskStatusDB`` file as output. | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > ls | ||
| warehouse_tyk2/ tasks_tyk2.db | ||
|
|
||
|
|
||
| .. note:: | ||
|
|
||
| If you're migrating from Transformation-based execution with quickrun, know that the ``Warehouse`` directory contains all the information that a directory of transformation.json files store, just in a different structure. | ||
|
|
||
|
|
||
| Running the Campaign | ||
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| To execute the campaign all we need is the ``Warehouse`` and a ``TaskStatusDB`` which handle storage and orchestration, respectively. | ||
|
|
||
| At any time, you can query the execution status of the campaign using ``openfe status``. | ||
| All task status information is stored in the ``TaskStatusDB``: | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe status --task-db tasks_ty2k.db | ||
| ┌─────────────────────────────────┬───────────┬───────────────┬───────┬───────────┐ | ||
| │ taskid │ status │ last_modified │ tries │ max_tries │ | ||
| ├─────────────────────────────────┼───────────┼───────────────┼───────┼───────────┤ | ||
| │ HybridTopologySetupUnit-025f3a… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologySetupUnit-70535a… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologySetupUnit-4eb000… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologySetupUnit-016551… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologyMultiStateSimula… │ BLOCKED │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologyMultiStateSimula… │ BLOCKED │ NaT │ 0 │ 1 │ | ||
| ... | ||
|
|
||
|
|
||
| **Tip**: you can use the ``--summary`` flag to show a summary table of the number of tasks with each status: | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe status --task-db tasks_ty2k.db | ||
| ┏━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┓ | ||
| ┃ status ┃ n_tasks ┃ | ||
| ┡━━━━━━━━━━━━━━━━━━╇━━━━━━━━━┩ | ||
| │ BLOCKED │ 1 │ | ||
| │ AVAILABLE │ 0 │ | ||
| │ IN_PROGRESS │ 0 │ | ||
| │ COMPLETED │ 10 │ | ||
| │ TOO_MANY_RETRIES │ 1 │ | ||
| │ ERROR │ 0 │ | ||
| └──────────────────┴─────────┘ | ||
|
|
||
| .. TODO: explain task dag? maybe save that for developer docs? | ||
|
|
||
| To execute a single ``task`` (where here a ``task`` is one ``ProtocolUnit``), you can simply run: | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe run-task --warehouse warehouse_tyk2/ --task-db tasks_tyk2.db | ||
|
|
||
| This finds next available ``task`` in the ``TaskStatusDB``, retrieves the necessary data from the ``Warehouse`` to execute the task, then executes the task. | ||
|
|
||
| You'll now see that one task has been completed, and a new task has been unblocked: | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe status --task-db tasks_ty2k.db | ||
|
|
||
| ┌───────────────────────────┬───────────┬─────────────────────┬───────┬───────────┐ | ||
| │ taskid │ status │ last_modified │ tries │ max_tries │ | ||
| ├───────────────────────────┼───────────┼─────────────────────┼───────┼───────────┤ | ||
| │ HybridTopologySetupUnit-… │ COMPLETED │ 2026-09-09 18:02:13 │ 1 │ 1 │ | ||
| │ HybridTopologySetupUnit-… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologySetupUnit-… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologySetupUnit-… │ AVAILABLE │ NaT │ 0 │ 1 │ | ||
| │ HybridTopologyMultiState… │ AVAILABLE │ 2026-09-09 18:02:13 │ 0 │ 1 │ | ||
| │ HybridTopologyMultiState… │ BLOCKED │ NaT │ 0 │ 1 │ | ||
| ... | ||
|
|
||
| However, to run an entire campaign you would have to run this single command _many_ times. | ||
|
|
||
| In practice, you will likely be submitting many workers simultaneously using SLURM or similar. | ||
| You can call this command in a loop, so that after a ``task`` is completed, the ``Worker`` automatically picks up a new ``task``, continuing to run tasks in serial until the walltime runs out. | ||
|
|
||
| .. code:: bash | ||
| :caption: run_tasks.sh | ||
|
|
||
| #!/bin/bash | ||
|
|
||
| #SBATCH --job-name="openfe job" | ||
| #SBATCH --mem-per-cpu=2G | ||
|
|
||
| # activate an appropriate conda environment, or any "module load" commands required | ||
| conda activate openfe_env | ||
|
|
||
| # continue submitting run-task in serial until the wall time is hit | ||
| # you may submit this *script* multiple times to have workers execute tasks in parallel | ||
| while true; do | ||
| openfe run-task --warehouse my_campaign/ --task-db my_campaign.db --scratch workdir/ | ||
| done | ||
|
|
||
|
|
||
| To run multiple workers in parallel, submit ``run_tasks.sh`` multiple times as separate jobs. | ||
|
|
||
|
|
||
| Gathering Results | ||
| ----------------- | ||
|
|
||
| In addition to the input data, the ``Warehouse`` directory contains every ``ProtocolUnitResult`` created during execution. | ||
|
|
||
| Because task-based execution is currently under development, there is not yet a direct command to output the results. | ||
| To enable complete workflows in the meantime, we provide the ``to-legacy-json`` CLI command that takes in a Warehouse directory and outputs the results in a format identical to the format used by ``openfe quickrun``. | ||
|
|
||
| This enables use of ``openfe gather`` (and ``openfe gather-septop``, ``openfe gather-abfe``). | ||
|
|
||
| .. code:: bash | ||
|
|
||
| > openfe to-legacy-json warehouse_tyk2/ -o tyk2_result_jsons | ||
|
|
||
|
|
||
| The ``results`` directory may now be used as input to ``openfe gather``. | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Changed:** | ||
|
|
||
| * Changed CLI sections from "Network Planning", "Quickrun Exectutor" and "Miscellaneous" to "Planning & Setup", "Execution", "Results Gathering", and "Miscellaneous". | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| **Added:** | ||
|
|
||
| .. TODO: add details | ||
| * Added CLI commands for running task-based execution (`PR #2174 <https://github.com/OpenFreeEnergy/openfe/pull/2174>`_). | ||
| * Added ``--networks-only`` option to ``openfe plan-rbfe-network`` and ``openfe plan-rhfe-network`` CLI commands to only output the AlchemicalNetwork JSON file and LigandNetwork graphml file, but construct none of the Transformation JSON files. | ||
| This option is useful for preparing inputs for task-based execution (`PR #2174 <https://github.com/OpenFreeEnergy/openfe/pull/2174>`_). | ||
|
|
||
| **Changed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * Added ``openfe status`` command (`PR #2156 <https://github.com/OpenFreeEnergy/openfe/pull/2156>`_) that shows the status of all tasks in a worker task database. | ||
|
|
||
| **Changed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * Added ``--summary`` flag to the ``openfe status`` command that shows the each task status type and the number of tasks with that status (`PR #2201 <https://github.com/OpenFreeEnergy/openfe/pull/2201>`_). | ||
|
|
||
| **Changed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * Added ``openfe.storage.warehouse``, which includes ``WarehouseBaseClass`` and the example implementation ``FileSystemWarehouse``. | ||
|
|
||
| **Changed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * Removed the unused methods ``metadatastore``, ``resultclient``, and ``resultserver`` from ``openfe.storage``. | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| from exorcist.taskdb import TaskStatusDB | ||
|
|
||
| from .exorcist_utils import ( | ||
| get_dependency_df, | ||
| get_task_df, | ||
| setup_task_campaign, | ||
| ) | ||
| from .worker import Worker |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD if this should stay. see #2171 (comment)