supervisor=s6: eval command first and don't invoke a shell at run-time - #1053
Merged
Conversation
supervise-daemon uses 'eval' once to evaluate shell constructs in the definition of command, command_args and command_args_foreground. And then it launches $command directly. So it doesn't support deeply nested shell constructs and using a full run-time shell to evaluate $command is unnecessary. So we do the same when building the run script for s6: we eval at run script build time, and the result invokes $command directly, without going through a shell. This is much cleaner, especially since the rest of the run script is execline i.e. already shell-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supervise-daemon uses 'eval' once to evaluate shell constructs in the definition of command, command_args and command_args_foreground. And then it launches $command directly. So it doesn't support deeply nested shell constructs and using a full run-time shell to evaluate $command is unnecessary.
So we do the same when building the run script for s6: we eval at run script build time, and the result invokes $command directly, without going through a shell. This is much cleaner, especially since the rest of the run script is execline i.e. already shell-free.