Skip to content

shared: fix open_rwfifo descriptor handling #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navi-desu merged 1 commit into from
Jul 31, 2026
+2 −2
Merged

shared: fix open_rwfifo descriptor handling #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/shared/helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,14 @@ RC_UNUSED static int open_rwfifo(const char *path, bool nonblock)
* On linux, opening O_RDWR would solve this, but posix
* leaves that behaviour undefined, and for example, hurd
* does not properly handle it. */
if ((w = open(path, O_WRONLY | O_NONBLOCK | O_CLOEXEC) == -1)) {
if ((w = open(path, O_WRONLY | O_NONBLOCK | O_CLOEXEC)) == -1) {
err = errno;
goto r_err;
}

if (!nonblock) {
int flags = fcntl(r, F_GETFL);
if (flags == -1 || fcntl(r, flags & ~O_NONBLOCK) == -1) {
if (flags == -1 || fcntl(r, F_SETFL, flags & ~O_NONBLOCK) == -1) {
err = errno;
goto w_err;
}
Expand Down
Loading