Bug async_repeat_request. Update async.c - #3916
Closed
vadimd333 wants to merge 1 commit into
Closed
Conversation
bogdan-iancu
requested changes
Jun 11, 2026
| * with data from current msg */ | ||
| if ((t->uas.request) && (route_type==REQUEST_ROUTE)) | ||
| if ((t->uas.request) && (route_type==REQUEST_ROUTE) && | ||
| ((msg->msg_flags & FL_TM_FAKE_REQ) == 0)) |
Member
There was a problem hiding this comment.
@vadimd333 , I'm not questioning the leak (and its fixing), but with this change, the transaction will not be updated from a faked request (like after a async call).
So, if you have this scenario:
- incoming request changed (changeA) in request route
- async jump (a first update will be done here, pushing the changeA into transaction)
- resume in script, doing another set of changes (changeB)
- async jump (no update here the request used in the async resume is a FAKE one)
-> we will loose the changeB, right ?
Member
|
This fix is not the correct one, the replacement is here d5d1760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3914
Summary
Details
Solution
Compatibility
Closing issues