feat(utils): reduce recursion in the Arrays sort to support larger arrays - #171
Merged
Merged
Conversation
Collaborator
|
Add a large-array sort test (random and pre-sorted input) so the bounded recursion depth is covered by CI. |
…arrays ## Summary Ports [OpenZeppelin/openzeppelin-contracts#6324](OpenZeppelin/openzeppelin-contracts#6324) from openzeppelin-contracts 5.7.0. `_quickSort` now iterates on the larger partition and only recurses into the smaller one, bounding recursion depth so sorting large arrays no longer risks stack overflow. Changed in the `scripts/generate/templates/Arrays.js` template and regenerated into `Arrays.sol`.
luiz-lvj
force-pushed
the
feat/arrays-larger-sort
branch
from
September 16, 2026 14:22
fc11482 to
d367f56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports OpenZeppelin/openzeppelin-contracts#6324 from openzeppelin-contracts 5.7.0.
_quickSortnow iterates on the larger partition and only recurses into the smaller one, bounding recursion depth so sorting large arrays no longer risks stack overflow. Changed in thescripts/generate/templates/Arrays.jstemplate and regenerated intoArrays.sol.