Conversation
…rsion ## Summary Ports [OpenZeppelin/openzeppelin-contracts#6631](OpenZeppelin/openzeppelin-contracts#6631) from openzeppelin-contracts 5.7.0. **Breaking change.** `TIP712` no longer falls back to storage for long `name`/`version` values. The constructor now uses `toShortString()` (and the accessors `toString()`), so both parameters must fit in a `ShortString` (≤31 bytes) or the constructor reverts with `ShortStrings.StringTooLong`. Storing the domain exclusively in immutables keeps it consistent — and downstream `TRC7739` verification correct — when the contract is used behind a proxy or clone without an initializer. The `_nameFallback`/`_versionFallback` slots are kept (deprecated) to preserve the storage layout of contracts that inherit `TIP712` behind a proxy. TRON specifics: - The domain separator's `block.chainid & 0xffffffff` masking (the only TIP-712 vs EIP-712 difference) is untouched. - The port carried a TRON-only WARNING paragraph describing the now-removed fallback behavior; it is replaced by upstream's IMPORTANT note about the 31-byte limit. - `scripts/upgradeable/upgradeable.patch` is regenerated so the `-upgradeable` transpile still applies (the upgradeable variant stores `name`/`version` as plain strings and is unaffected by this change), mirroring upstream, which updated its own transpiler patch in the same PR.
luiz-lvj
force-pushed
the
feat/tip712-drop-storage-fallback
branch
from
September 16, 2026 14:24
15999b4 to
fe245a7
Compare
…k drop The transpiler patch's TIP712.test.js hunk targeted the old short/long test structure and no longer applied after #174 dropped the storage fallback, failing the tests-upgradeable job at patch-apply. Regenerate it so patch-apply is clean: drop the proxy test and rewrite the long name/version cases to assert the upgradeable (string-storage) variant supports them, mirroring upstream's own upgradeable patch for openzeppelin-contracts#6631.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports OpenZeppelin/openzeppelin-contracts#6631 from openzeppelin-contracts 5.7.0. Breaking change.
TIP712no longer falls back to storage for longname/versionvalues. The constructor now usestoShortString()(and the accessorstoString()), so both parameters must fit in aShortString(≤31 bytes) or the constructor reverts withShortStrings.StringTooLong. Storing the domain exclusively in immutables keeps it consistent — and downstreamTRC7739verification correct — when the contract is used behind a proxy or clone without an initializer. The_nameFallback/_versionFallbackslots are kept (deprecated) to preserve the storage layout of contracts that inheritTIP712behind a proxy.TRON specifics:
block.chainid & 0xffffffffmasking (the only TIP-712 vs EIP-712 difference) is untouched.scripts/upgradeable/upgradeable.patchis regenerated so the-upgradeabletranspile still applies (the upgradeable variant storesname/versionas plain strings and is unaffected by this change), mirroring upstream, which updated its own transpiler patch in the same PR.