forked from prebid/prebid-server-java
-
Notifications
You must be signed in to change notification settings - Fork 0
optable-targeting: Hid plus id5 Mobile In-app resolver params #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
softcoder594
wants to merge
25
commits into
optable-targeting-non-blocking-early-network-call
from
optable-targeting-hid-plus-id5-mobile-inapp-resolver-params
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8704aa5
optable-targeting: add hid (resolver hint) support
223e166
optable-targeting: add app bundle and ver to the Targeting API call
36e0334
optable-targeting: Add id5_signature propagation from client to Targe…
cb1b017
optable-targeting: Add id5_signature propagation from Targeting API t…
b731a01
optable-targeting: code cleanup
c970cc6
optable-targeting: fix NPE when optableTargetingCall was never set at…
fa4a6d2
optable-targeting: Encode Targeting API query params
cd55d19
optable-targeting: improve hid prefixes parsing
7928105
optable-targeting: Remove dead code
af2e672
optable-targeting: Improve id5 signature extraction from Targeting re…
4ae39fc
optable-targeting: Code cleanup
0dabf80
optable-targeting: update README.md
de40bf6
optable-targeting: Code cleanup
603fd5c
optable-targeting: Update cache key
4da5787
optable-targeting: Replace em-dashes in README
justadreamer ab01858
optable-targeting: Fix double rendering of query attributes
05520b6
optable-targeting: add Targeting API failure branch to bidder request…
a609072
optable-targeting: Remove redundant dependency
23a1548
optable-targeting: improve tests coverage
609d416
optable-targeting: don't add blank id5_signature into a query
40be6ae
optable-targeting: remove id5_signature resolving for bidders which a…
ce92ffb
optable-targeting: render id5_signature only if targeting enabled
6f0afee
optable-targeting: split targeting and id5 features rendering
765a538
optable-targeting: fix NoBids test to use a bid-less response
justadreamer bde6c04
optable-targeting: remove editor and AI tool config committed by mistake
justadreamer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...-targeting/src/main/java/org/prebid/server/hooks/modules/optable/targeting/model/App.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.prebid.server.hooks.modules.optable.targeting.model; | ||
|
|
||
| import lombok.Value; | ||
|
|
||
| @Value(staticConstructor = "of") | ||
| public class App { | ||
|
|
||
| String bundle; | ||
|
|
||
| String ver; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,8 @@ public class OptableAttributes { | |
| String userAgent; | ||
|
|
||
| Long timeout; | ||
|
|
||
| App app; | ||
|
|
||
| String id5Signature; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,6 @@ public class ExtUserOptable extends FlexibleExtension { | |
| String zip; | ||
|
|
||
| String vid; | ||
|
|
||
| String id5Signature; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...ava/org/prebid/server/hooks/modules/optable/targeting/v1/core/ExtUserOptableResolver.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package org.prebid.server.hooks.modules.optable.targeting.v1.core; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import org.prebid.server.hooks.modules.optable.targeting.model.openrtb.ExtUserOptable; | ||
| import org.prebid.server.json.ObjectMapperProvider; | ||
| import org.prebid.server.log.ConditionalLogger; | ||
| import org.prebid.server.log.LoggerFactory; | ||
|
|
||
| public class ExtUserOptableResolver { | ||
|
|
||
| private static final ConditionalLogger conditionalLogger = | ||
| new ConditionalLogger(LoggerFactory.getLogger(ExtUserOptableResolver.class)); | ||
|
|
||
| private ExtUserOptableResolver() { | ||
| } | ||
|
|
||
| public static ExtUserOptable resolveExtUserOptable(JsonNode node, double logSamplingRate) { | ||
| try { | ||
| return ObjectMapperProvider.mapper().treeToValue(node, ExtUserOptable.class); | ||
| } catch (JsonProcessingException e) { | ||
| conditionalLogger.warn("Can't parse $.ext.user.Optable tag", logSamplingRate); | ||
| return null; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.