Skip to content

Five Font Awesome 4 icon names render nothing (FA4 names on a FA5 dependency) #696

Description

@codeGlaze

Five icon names in source are Font Awesome 4 spellings. The project depends on
org.webjars/font-awesome 5.13.1, where those names do not exist, so the elements render
nothing — on every browser, with the font loading correctly.

location in source should be
src/cljs/orcpub/dnd/e5/views/import_log.cljs:63 fa-pencil fa-pencil-alt
src/cljs/orcpub/dnd/e5/views/import_log.cljs:192 :icon "fa-pencil" fa-pencil-alt
src/cljs/orcpub/dnd/e5/views/import_log.cljs:39 fa-exchange fa-exchange-alt
src/cljs/orcpub/dnd/e5/views/conflict_resolution.cljs:17 fa-circle-o / fa-dot-circle-o far fa-circle / far fa-dot-circle
src/clj/orcpub/styles/core.clj:1127 .fa-caret-square-o-down dead selector, matches nothing

The replacements are not guesses: they come from metadata/shims.json inside the webjar the
project already depends on. FA5 replaced the -o suffix with style prefixes (far is the old
"outline") and renamed 463 icons.

The sharpest case is conflict_resolution.cljs:17, the radio indicator in the homebrew import
conflict modal. .radio-icon has width:16px, so it reserves the space and draws nothing;
selection stays legible from the border colour, which is probably why nobody has reported it.

Five is the complete set — all 44 fa-* names in source were checked against the webjar's
1,605 SVGs. The webjar also ships css/v4-shims.css, which would fix all five in one
include-css, but renaming five is cheaper than carrying a 463-entry shim.

One trap for whoever fixes it: fa-pencil\b matches inside fa-pencil-alt, so a naive grep
also reports views.cljs:8520 as broken. That one is already correct.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions