Fix Fist of War, Ancestral Empowerment and Ancestral Call not applying to damage - #2538
Open
juddisjudd wants to merge 1 commit into
Open
juddisjudd wants to merge 1 commit into
juddisjudd wants to merge 1 commit into
Conversation
…g to damage PathOfBuildingCommunity#2494 moved calcAncestralBoost and calcCombinedAncestralBoost out of the per-pass loop in calcs.offence. Inside the loop `output` is pass.output, but at function scope it is actor.output, so the *DamageEffect multipliers were written to the wrong table and the per-pass values used in allMult stayed at 1. Slam builds lost the whole ancestral boost (about 24% on a Titan Supercharged Slam build with Fist of War). Pass the per-pass output table into both helpers explicitly.
juddisjudd
added a commit
to pobredux/pob-redux
that referenced
this pull request
Sep 20, 2026
…e Fist of War fix as a pob-sync patch pob-sync applies patches/<game>/*.patch after copying, so a fix upstream has not merged yet can ship without editing the vendored files. The first one is the Fist of War / Ancestral boost fix that held the pin at 1bcdb485c since 2026-09-09, now open upstream as PathOfBuildingCommunity/PathOfBuilding-PoE2#2538.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
#2494 moved
calcAncestralBoostandcalcCombinedAncestralBoostout of the per-pass loop incalcs.offence. Inside the loopoutputispass.output; at function scope it isactor.output. Both helpers still writeoutput[skillNameVar .. "DamageEffect"], so the Fist of War, Ancestral Empowerment and Ancestral Call multipliers land on the actor table and the per-pass values thatallMultreads stay at 1. Slam builds lose the whole ancestral boost.This change passes the per-pass
outputtable into both helpers as a parameter.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/X2pETqLn5L7B
Before screenshot:
Hit DPS 176,750 at ce566ea (numbers above; no screenshot).
After screenshot:
Hit DPS 243,177 with this change.