Conversation
vaisest
force-pushed
the
graph-plot-chart
branch
3 times, most recently
from
September 23, 2026 00:16
6a35b3f to
a6cd0e5
Compare
vaisest
marked this pull request as ready for review
September 23, 2026 00:16
vaisest
force-pushed
the
graph-plot-chart
branch
from
September 23, 2026 04:18
a6cd0e5 to
bc6dec4
Compare
vaisest
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Most people don't seem to know that evasion, deflection, and armour aren't just flat reductions. This isn't helped by the game itself giving a single value, and by PoB only having one value unless you manually adjust the enemy parameters. This aims to clarify that. These graphs aren't meant to be inspected super closely, but are more meant to show how e.g. a small amount of armor does nothing against big hits while showing that it's useful for lots of smaller hits.
These are mostly inspired by Ninja's overview graphs. The code intentionally doesn't do much in the calc code as I feel it's busy enough as is. The draw function is also not very generalised.
Steps taken to verify a working solution:
Todo:
Link to a build that showcases this PR:
Twister with a bit of every defensive stat: https://poe.ninja/poe2/pob/29daf
Armour enjoyer with elemental armour: https://poe.ninja/poe2/pob/29db0
Neither: https://poe.ninja/poe2/pob/29db2
After screenshot:
Path.space.of.space.Building-PoE2_2026-09-23_16-43-48.mp4