replace lowest/max double bounds with +/- infinity - #378
Conversation
| double_no_upper_bound: | ||
| type: double | ||
| default_value: .inf | ||
| validation: | ||
| gt_eq<>: 0 |
There was a problem hiding this comment.
Note to myself: The change appears in example_python because the C++ parameter file is symlinked to this one.
|
kind of duplicate of #169. Have you checked if rqt_reconfigure handles this properly? I remember opening a PR there, but not sure now |
Do you remember what exactly the problem with When I start the and set a value, it is applied and I can retrieve it again via: ros2 param get /admittance_controller double_no_upper_boundThe slider goes from 0 to inf, so using the slider does not make too much sense. But setting it manually via the text field works as expected. I get a couple of "The range of this parameter is too large for the slider to handle. Scaling down to fit within 32 bits with factor 2.328306435454494e-10." warnings, but those apply to some integer values. |
b3a87dd to
7af4067
Compare
The double bounds use
lowest/maxon C++, while the Python implementation uses +/-float('inf').Align the implementations by replacing
lowest/maxwith +/-infinity.Original issue discovered by @pum1k in #376 (comment).
Fixes #376 .