Skip to content

replace lowest/max double bounds with +/- infinity - #378

Open
christianrauch wants to merge 2 commits into
PickNikRobotics:mainfrom
christianrauch:fix_double_bounds
Open

replace lowest/max double bounds with +/- infinity#378
christianrauch wants to merge 2 commits into
PickNikRobotics:mainfrom
christianrauch:fix_double_bounds

Conversation

@christianrauch

@christianrauch christianrauch commented Aug 9, 2026

Copy link
Copy Markdown

The double bounds use lowest/max on C++, while the Python implementation uses +/- float('inf').

Align the implementations by replacing lowest/max with +/- infinity.

Original issue discovered by @pum1k in #376 (comment).

Fixes #376 .

Comment on lines +348 to +352
double_no_upper_bound:
type: double
default_value: .inf
validation:
gt_eq<>: 0

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: The change appears in example_python because the C++ parameter file is symlinked to this one.

@christophfroehlich

Copy link
Copy Markdown
Collaborator

kind of duplicate of #169. Have you checked if rqt_reconfigure handles this properly? I remember opening a PR there, but not sure now

@christianrauch

Copy link
Copy Markdown
Author

kind of duplicate of #169. Have you checked if rqt_reconfigure handles this properly? I remember opening a PR there, but not sure now

Do you remember what exactly the problem with rqt_reconfigure was?

When I start the rqt_reconfigure plugin via

QT_QPA_PLATFORM=xcb rqt --standalone rqt_reconfigure.param_plugin.ParamPlugin

and set a value, it is applied and I can retrieve it again via:

ros2 param get /admittance_controller double_no_upper_bound

The slider goes from 0 to inf, so using the slider does not make too much sense. But setting it manually via the text field works as expected.

I get a couple of "The range of this parameter is too large for the slider to handle. Scaling down to fit within 32 bits with factor 2.328306435454494e-10." warnings, but those apply to some integer values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.inf not within floating point range

2 participants