Fix: Enable MPPI open_loop to restore hangar_sim nav speed - #840
Draft
bkanator wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
needs: moveit_pro/#21347
Warning
Inert until moveit_pro#21347 merges.
open_loopis silently ignored by the stock Jazzynav2_mppi_controller, which does not declare the parameter. This only takes effect once the image ships the patched build.Problem
The
hangar_simbase drives at roughly a third of its configured speed on Jazzy. MPPI seeds each control cycle's rollout from the last reported velocity (/odom) rather than its own last commanded velocity, so lagging odometry re-anchors the optimizer near the current speed every cycle.Measured here (
vx_max: 0.5, 6 m goal):vx_max)Raising
vx_maxalone does nothing (0.5 → 1.5 changed nothing), so this is not tuning.Part of PickNikRobotics/moveit_pro#21202.
Approach
One parameter.
open_loopcomes from ros-navigation/navigation2#5617, which is merged to nav2mainbut was never backported to the Jazzy release; moveit_pro#21347 pins a build that carries it. The comment records why the setting exists so it is not mistaken for arbitrary tuning.Release notes
None