Skip to content

Fix: Enable MPPI open_loop to restore hangar_sim nav speed - #840

Draft
bkanator wants to merge 1 commit into
mainfrom
feat/nav2-mppi-open-loop
Draft

Fix: Enable MPPI open_loop to restore hangar_sim nav speed#840
bkanator wants to merge 1 commit into
mainfrom
feat/nav2-mppi-open-loop

Conversation

@bkanator

Copy link
Copy Markdown

[written by AI]

needs: moveit_pro/#21347

Warning

Inert until moveit_pro#21347 merges. open_loop is silently ignored by the stock Jazzy nav2_mppi_controller, which does not declare the parameter. This only takes effect once the image ships the patched build.

Problem

The hangar_sim base drives at roughly a third of its configured speed on Jazzy. MPPI seeds each control cycle's rollout from the last reported velocity (/odom) rather than its own last commanded velocity, so lagging odometry re-anchors the optimizer near the current speed every cycle.

Measured here (vx_max: 0.5, 6 m goal):

Before After
Commanded mean 0.165 m/s 0.466 m/s
Commanded max 0.173 m/s 0.500 m/s (reaches vx_max)
Ground-truth mean 0.138 m/s 0.452 m/s

Raising vx_max alone does nothing (0.5 → 1.5 changed nothing), so this is not tuning.

Part of PickNikRobotics/moveit_pro#21202.

Approach

One parameter. open_loop comes from ros-navigation/navigation2#5617, which is merged to nav2 main but was never backported to the Jazzy release; moveit_pro#21347 pins a build that carries it. The comment records why the setting exists so it is not mistaken for arbitrary tuning.

Release notes

None

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e4635021-06b5-4236-b275-6123b773e121

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

  • lab_sim
    • jazzy: no report produced — see run logs
  • hangar_sim
    • jazzy: no report produced — see run logs

@bkanator bkanator added this to the 10.0.1 milestone Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant