fix(bookings): keep user input entered while the booking form initialises

[camreeves]

Fixes PPT-2643.

The bug

BookingFormService.newForm() defers itself until the current user has loaded:

if (!currentUserIsLoaded()) {
    currentUserLoaded().then(() => this.newForm(type, booking));
    return;   // <- returns; the form is already rendered and interactive
}
...
this.model.set(bookingFormValue(new Booking()));   // <- wipes
this.form().reset();                               // <- wipes

The form accepts input during that window. When initialisation completes it resets, silently discarding whatever was entered: title reverts to the default Booking, All Day switches back off, Require locker switches back on.

On a fast connection nobody notices because init finishes first. On a slow one you start typing a title and it vanishes a second later. It affects every flow through this shared service, so desk, locker, parking, visitor and room, across workplace and the other booking UIs.

The fix

Option A from the ticket: preserve the input rather than gate interactivity.

The user's edits are captured on the way back into newForm and replayed over the incoming booking. Only fields the user actually touched are carried, read from the signal-forms dirty flags, so programmatic writes (_patch, model.set) are ignored and a field the user never touched still takes its value from the booking being opened.

Placement matters and is commented in the source. The replay happens after the main patch but before applyDurationSettings(), so a restored all_day still drives the time-sync window, and before _syncWindowIfUnchanged(), which compares against the initial window and so yields to a user-changed one without any extra handling.

The capture is set synchronously immediately before the re-entry, so there is no window in which a normal newForm call could consume edits meant for a deferred one.

I did not take Option B (gating interactivity behind a loader) because it is a visible UX change across every booking flow and is yours to call.

Testing

Three specs in booking-form.service.spec.ts under initialisation while the user is still loading.

No mocking. currentUserIsLoaded() reports "loaded" whenever it detects a test runtime, so the tests neutralise that runtime probe to reach the deferred branch, which keeps the real promise plumbing in currentUserLoaded() under test rather than a stub of it.

Red-checked against unfixed code, where two of the three fail with exactly the ticket's symptoms:

AssertionError: expected 'Booking' to be 'Quiet corner desk'
AssertionError: expected false to be true

The third (does not resurrect that input on the next new form) passes either way by design. It guards against the new code leaking preserved edits into a later form rather than reproducing the original bug.

• nx test bookings — 393 passed
• nx affected -t test — 25 projects, all passed
• nx affected -t build — 16 projects, all built

nx lint fails in this workspace on untouched libraries too (Failed to load config "plugin:@angular-eslint/recommended"), so it is pre-existing and unrelated.

Follow-up

The workplace e2e suite currently works around this bug in bookDeskViaUI with a converging retry block, which means it no longer detects it. Once this merges that workaround should come out and be replaced with a spec asserting input survives initialisation. That lives on the e2e branches (#476/#477) and is not touched here.

How it was found: the new e2e suite, which produced bookings saved under the wrong title locally and an unopenable confirm dialog in CI (a reverted All Day leaves the default 5-minute slot, which on a slow run has already passed and invalidates the form).

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
frontend-templates	Ignored		Aug 4, 2026 3:54am

[MrYuion]

LGTM