ci(e2e): run the suite on the branches we deploy from - #482
Merged
Conversation
Stage 2. `push` now covers develop, release/** and rc/** — the same set build.yml deploys from — alongside the existing e2e/** and the nightly. A regression is now caught where it lands, which is when bisecting is cheapest, and since this repo has no pull_request trigger (public repo, self-hosted runner) it is also the only way merges get covered at all. Still advisory, and still structurally unable to block: different runner pool, no cross-workflow needs, not a required status check, and the job name says so. Still not feature branches — one runner binding fixed host ports means runs serialise, and a busy trigger set would starve the nightly.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2 of the trigger rollout that #476 set up.
pushnow covers develop, release/**, rc/** — the same branch setbuild.ymldeploys from — alongside the existinge2e/**and the nightly.Why now
The suite has run green on every invocation since it merged: 14/14 on the self-hosted runner, verified on develop and on branch pushes. A regression now gets caught where it lands, when bisecting is cheapest. And since this repo has no
pull_requesttrigger — public repo plus self-hosted runner — pushes are the only way merges get covered at all.What has not changed
Still advisory, and still structurally unable to block anything: different runner pool from
build.yml, no cross-workflowneeds, not a required status check, and the job is named "advisory — does not block builds" so a red X beside the build jobs cannot be misread.Still not feature branches. There is one self-hosted runner binding fixed host ports, so runs serialise; a busy trigger set would build a queue that starves the nightly. Use Run workflow for a one-off.
🤖 Generated with Claude Code