Write the registered header into the Track M artifact - #478
Merged
Merged
Conversation
run_track_m_registered.main built the artifact as {"header": REGISTERED_HEADER, ..., **result, ...}. The pipeline's result carries its own "header": the dry-run header for invented data, None for a registered run. Spreading the result overwrote the registered header, so a registered run would have written "header": null.
The independent review of Registration 17 (2026-09-27) found this. Its fix is applied: the header is restored after the dictionary is built, and the key keeps its first place in the written JSON.
The new regression test drives main with stand-in preflight, parameters and computation, and an INVENTED pipeline result that includes "header": None. It asserts that the written artifact's header is REGISTERED_HEADER and is the first key. It fails without the fix. The existing header test checked only the constant.
No rule, row, statistic, parameter or guard changes. The M1 specification is unchanged: SHA-256 2e55afc1..., m1-ratified-1, blocked_by []. Tier manifest recollected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a defect the independent review of exercise 4's Registration 17 found before posting. A registered Track M run would have written
"header": nullinto its artifact.Cause.
run_track_m_registered.mainbuilds the artifact as{"header": REGISTERED_HEADER, …, **result, …}. The pipeline's result carries its ownheader: the dry-run header for invented data, andNonefor a registered run. Spreading the result overwrote the registered header.Fix. Restore
artifact["header"] = REGISTERED_HEADERafter the dictionary is built. This is the review's prescribed fix. The key keeps its first place in the written JSON.Test.
test_main_writes_the_registered_header_over_the_pipelinesdrivesmainwith stand-in preflight, parameters and computation, and an INVENTED pipeline result that includes"header": None. It asserts that the written artifact's header isREGISTERED_HEADERand is the first key, and that the one-shot flags and the rows are carried. It fails without the fix. The existing header test checked only the constant.Invariant. Whatever the pipeline returns, the written registered artifact begins with the registered header.
No rule, row, statistic, parameter or guard changes. The M1 specification is unchanged: SHA-256
2e55afc1…,m1-ratified-1,blocked_by: []. The Track M set: 418 passed. Tier manifest: 8,438.This PR's merge commit will be the commit Registration 17 registers.
🤖 Generated with Claude Code