Eliminate internal string buffering and write directly to stdout - #142
Open
Bowen951209 wants to merge 8 commits into
Open
Eliminate internal string buffering and write directly to stdout#142Bowen951209 wants to merge 8 commits into
Bowen951209 wants to merge 8 commits into
Conversation
- Remove the `buffer` field in `State` struct. Directly write strings to stdout. - Refactor `trim_trailing_zeros()` to `write_with_precision()` because we cannot use string buffer. Tests are thus modified. - Remove sonic-rs dependency. We needed a struct to store text and tooltip strings for sonic-rs. Since the string buffer allocations are diminished, sonic-rs is no longer useful.
json_escape_simd::escape wraps quotation marks around a string. Remove them rather than reducing the quotation marks in write_json_unchecked because of readability.
Validate JSON using sonic_rs, so re-introduced sonic_rs dep.
- Assert the output length is less than 1024 (the stdout line buffer size) - Assert the output only contains a line break at the last character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor optimization.
State.buffer: Output is now streamed directly to the standard output.trim_trailing_zeros()withwrite_with_precision(). This allows us to format numbers directly into the output stream without needing a back-buffer for post-processing.