bug: strip exclusiveMinimum and exclusiveMaximum from Vertex tool schemas - #1799
Open
Tyagiquamar wants to merge 1 commit into
Open
bug: strip exclusiveMinimum and exclusiveMaximum from Vertex tool schemas#1799Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1473.
What
Tool calls with JSON-schema numeric bounds (exclusiveMinimum/exclusiveMaximum, emitted by MCP servers and schema generators) fail on Vertex AI with 400 Unknown name, even though the same tools work elsewhere.
Why
The Vertex Schema reference does not support those keywords. The gateway sanitizer removed additionalProperties and dollar-schema but left these in, so any tool schema using numeric bounds was rejected upstream.
Root cause
recursivelyDeleteUnsupportedParameters in src/providers/google-vertex-ai/utils.ts (used by both the vertex-ai and google provider tool paths) did not strip exclusiveMinimum/exclusiveMaximum.
Fix
Delete both keywords alongside the existing ones, recursively.
Tests