fix: draw the inert footnote underline with a border, not text-decoration (1.2.2) - #37
Merged
Merged
Conversation
…tion Obsidian's plugin CSS check maps the entire `text-decoration` family onto a single caniuse feature that Chrome supports only partially, so the longhands 1.2.1 switched to warn exactly like the shorthand did. Use a dotted `border-bottom` (plus `padding-bottom` for the offset) instead — same cue, CSS1 properties nothing has ever qualified. `scripts/validate.mjs` now fails on any `text-decoration*` declaration in styles.css: the reviewer's check runs on their side only, which is how the same warning came back a second time. Release 1.2.2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Xs98arTAdcat1h9pkz7Vy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsidian's 1.2.1 plugin review came back with one remaining warning:
Those two lines are the
text-decoration-line/text-decoration-stylelonghands 1.2.1 introduced, on the assumption that only the multi-value shorthand was flagged. That assumption was wrong: the reviewer's CSS check maps the wholetext-decorationfamily — shorthand and longhands alike — onto one caniuse feature that Chrome supports only partially, so no spelling of it can pass.Fix
The inert footnote marker's dotted underline is now a
border-bottom: 1px dotted currentColorwithpadding-bottom: 1pxstanding in for the underline offset. Same visual cue, out of CSS1 properties nothing has ever qualified. No behaviour change.Recurrence prevention
The reviewer's CSS check runs on their side only — the local gate could not verify the 1.2.1 fix, which is how the same warning came back a second time.
scripts/validate.mjsnow fails the build on anytext-decoration*declaration instyles.css, with the replacement spelled out in the failure message. Verified it trips on a planted declaration and reports the right line.Release
Bumps to 1.2.2 in lockstep:
manifest.json,versions.json("1.2.2": "1.6.6"),CHANGELOG.md.This branch is cut from
chore/back-merge-1.2.1, so merging it also lands the pendingmain→devback-merge.Gate
npm run lint·npm run build·node --check main.js·node scripts/validate.mjs— all green.🤖 Generated with Claude Code
https://claude.ai/code/session_019Xs98arTAdcat1h9pkz7Vy