Skip to content

Add Ornithe support to meta - #148

Open
Wyvest wants to merge 3 commits into
PrismLauncher:mainfrom
Wyvest:main
Open

Wyvest wants to merge 3 commits into
PrismLauncher:mainfrom
Wyvest:main

Conversation

@Wyvest

@Wyvest Wyvest commented Sep 8, 2026

Copy link
Copy Markdown

No description provided.

@Ryex
Ryex requested review from TheKodeToad and Trial97 September 9, 2026 05:39
@Ryex

Ryex commented Sep 9, 2026

Copy link
Copy Markdown
Member

this looks like it would achieve the desired result?

can you post an example of a generated ornithe version file? I don;t really feel like trying to run a local meta version right now

@Wyvest

Wyvest commented Sep 10, 2026

Copy link
Copy Markdown
Author

this looks like it would achieve the desired result?

can you post an example of a generated ornithe version file? I don;t really feel like trying to run a local meta version right now

net.ornithemc.fabric-loader
0.19.5.json
package.json

net.ornithemc.calamus-intermediary
package.json
b1.7.3.json
1.8.9.json
1.12.2.json

@Wyvest
Wyvest force-pushed the main branch 2 times, most recently from b436e6e to e6de732 Compare September 10, 2026 16:07
Assisted-by: Claude:claude-5-opus
Signed-off-by: Julian Chang <wyvest@polyfrost.org>
Signed-off-by: Julian Chang <wyvest@polyfrost.org>
Comment thread meta/run/generate_ornithe.py Outdated
Signed-off-by: Julian Chang <wyvest@polyfrost.org>

@TheKodeToad TheKodeToad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launcher doesn't care about the package.json, but it does the index.json - testing with your other PR:

Image

YongDo-Hyun added a commit to Project-Tick/meta that referenced this pull request Sep 16, 2026
@Wyvest

Wyvest commented Sep 16, 2026

Copy link
Copy Markdown
Author

The launcher doesn't care about the package.json, but it does the index.json - testing with your other PR:

Image

I cant reproduce this, did you run poetry run index

@TheKodeToad

Copy link
Copy Markdown
Member

I cant reproduce this, did you run poetry run index

I mean show me where this code is generating index.json? Because I don't see it
and I have everything else generated...

@Ryex

Ryex commented Sep 16, 2026

Copy link
Copy Markdown
Member

the index is a generic operation

@TheKodeToad

TheKodeToad commented Sep 16, 2026

Copy link
Copy Markdown
Member

Right, silly me (been a while since I had to do that since I was cloning the meta-launcher repo every time)

@TheKodeToad

TheKodeToad commented Sep 16, 2026

Copy link
Copy Markdown
Member

We should probably also add the Legacy Fabric version of LWJGL which is used in the official Ornithe Prism instance generator

In my testing on Linux the game crashes immediately on Java 25 (the preferred version) without it

Maybe we could add additional versions of the org.lwjgl component with the -legacyfabric suffix and suggest it in ornithe (though not sure whether the Minecraft or Ornithe suggested version would take precedence) or just say what the hell and overlay the version (seemed to work, I think at some point we started specifying libraries in lower components on the classpath earlier and I guess the latest natives also most likely take precidence, but I don't know if we can rely on it)

On a related note, something I have been thinking about is if there's a better name than intermediary mappings for the component depended on by the loader - it also includes several other libraries. Maybe it should be renamed to Ornithe Libraries or something, I don't know.

@TheKodeToad

Copy link
Copy Markdown
Member

Also, we should probably not just list 25 but some other jdk versions below it like the instance generator does too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants