feat(pass): allow copying multiple login fields at once - #529
Open
PAX-1-2 wants to merge 1 commit into
Open
Conversation
Add a multi-copy mode to the login item detail view: a toolbar lets the user enable field selection, pick fields through checkboxes (email, username, password, TOTP token, websites, note and custom fields) and copy them together as "Label: value" entries, separated either by comma and space or by line breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copying several fields of a login item currently requires copying them one by one. This adds a multi-copy mode to the login item detail view:
Label: valueentries joined either by ", " (comma and space) or by line breaks.copyToClipboardflow (respects the clipboard TTL setting and notifications).Example output:
Email: user@example.com, Username: johnor the same with one field per line.Implementation notes
MultiCopy.tsxinpackages/pass/components/Item/MultiCopy/exporting theuseMultiCopyhook, the selection checkbox and the toolbar.Login.content.tsxbuilds the list of selectable fields and swaps the field icon for the selection checkbox while the mode is enabled.ExtraFieldsControlgained two backwards-compatible optional props (copyable,renderIcon);OTPValueControl/UpgradeControlaccept aReactElementicon.core.generateOTP, so no extra OTP subscriptions are introduced.Testing
prettier --check,eslintandtsgo(check-types) pass on the changed files.