fix: whitelist NPC debuffs added in 1.4.5 - #3305
Merged
QuiCM merged 2 commits intoSep 9, 2026
Merged
Conversation
Bouncer.OnNPCAddBuff kicks any player whose client sends an NPC buff that is not in NPCAddBuffTimeMax. Five debuffs reachable from vanilla player actions were missing, so using the corresponding items kicked the player immediately: PotentAcid (395) Flask of Poison melee enchant ChlorophyteSpore (397) proj 1127 AcceleratePoisons (398) Catalyst Band BlueLightning (399) LightningStrikeShot (proj 1117) RedLightning (400) ArcSurge (proj 1122) Durations are the maxima from Projectile.StatusNPC and Player, so the existing time-based cheat detection is unchanged.
Contributor
Greptile SummaryAdds five Terraria 1.4.5 NPC debuffs and their vanilla maximum durations to the bouncer allowlist, preventing legitimate player actions from triggering NPC-buff cheat kicks.
Confidence Score: 5/5The PR appears safe to merge. The change narrowly extends the established NPC debuff allowlist, introduces no duplicate entries or rule violations, and preserves the existing duration-checking and kick behavior. Important Files Changed
Reviews (1): Last reviewed commit: "fix: whitelist NPC debuffs added in 1.4...." | Re-trigger Greptile |
lost-werewolf
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bouncer.OnNPCAddBuff kicks any player whose client sends an NPC buff that is not in NPCAddBuffTimeMax. Five debuffs reachable from vanilla player actions were missing, so using the corresponding items kicked the player immediately:
PotentAcid (395) Flask of Poison melee enchant
ChlorophyteSpore (397) proj 1127
AcceleratePoisons (398) Catalyst Band
BlueLightning (399) LightningStrikeShot (proj 1117)
RedLightning (400) ArcSurge (proj 1122)
Durations are the maxima from Projectile.StatusNPC and Player, so the existing time-based cheat detection is unchanged.