Skip to content

fix: whitelist NPC debuffs added in 1.4.5 - #3305

Merged
QuiCM merged 2 commits into
Pryaxis:general-develfrom
bulkinglb:fix/npc-buff-whitelist-1457
Sep 9, 2026
Merged

QuiCM merged 2 commits into
Pryaxis:general-develfrom
bulkinglb:fix/npc-buff-whitelist-1457

Conversation

@bulkinglb

Copy link
Copy Markdown
Contributor

Bouncer.OnNPCAddBuff kicks any player whose client sends an NPC buff that is not in NPCAddBuffTimeMax. Five debuffs reachable from vanilla player actions were missing, so using the corresponding items kicked the player immediately:

PotentAcid (395) Flask of Poison melee enchant
ChlorophyteSpore (397) proj 1127
AcceleratePoisons (398) Catalyst Band
BlueLightning (399) LightningStrikeShot (proj 1117)
RedLightning (400) ArcSurge (proj 1122)

Durations are the maxima from Projectile.StatusNPC and Player, so the existing time-based cheat detection is unchanged.

Bouncer.OnNPCAddBuff kicks any player whose client sends an NPC buff
that is not in NPCAddBuffTimeMax. Five debuffs reachable from vanilla
player actions were missing, so using the corresponding items kicked
the player immediately:

  PotentAcid (395)        Flask of Poison melee enchant
  ChlorophyteSpore (397)  proj 1127
  AcceleratePoisons (398) Catalyst Band
  BlueLightning (399)     LightningStrikeShot (proj 1117)
  RedLightning (400)      ArcSurge (proj 1122)

Durations are the maxima from Projectile.StatusNPC and Player, so the
existing time-based cheat detection is unchanged.
@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds five Terraria 1.4.5 NPC debuffs and their vanilla maximum durations to the bouncer allowlist, preventing legitimate player actions from triggering NPC-buff cheat kicks.

  • Allows Potent Acid, Chlorophyte Spore, Accelerate Poisons, Blue Lightning, and Red Lightning.
  • Retains the existing duration-based validation behavior for allowed NPC debuffs.

Confidence Score: 5/5

The PR appears safe to merge.

The change narrowly extends the established NPC debuff allowlist, introduces no duplicate entries or rule violations, and preserves the existing duration-checking and kick behavior.

Important Files Changed

Filename Overview
TShockAPI/Bouncer.cs Extends the NPC buff-duration allowlist with five vanilla Terraria 1.4.5 debuffs; no actionable issue was identified.

Reviews (1): Last reviewed commit: "fix: whitelist NPC debuffs added in 1.4...." | Re-trigger Greptile

@QuiCM
QuiCM enabled auto-merge September 9, 2026 09:50
@QuiCM
QuiCM disabled auto-merge September 9, 2026 09:53
@QuiCM
QuiCM merged commit 567da4c into Pryaxis:general-devel Sep 9, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants