fix(test): update the ForcedTradeStrategy fixture to the current engine listener API - #2
Merged
Merged
Conversation
…ne listener API The fixture no longer compiles against a current engine: onChange took a StateStoreSupport and called initStore(…) to bind a store field, both of which the engine removed. A listener now receives the resolved StateStore directly, as event data handed in with the values it belongs to, and the base class it extends was renamed AbstractOnChangeListener -> AbstractWindowListener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration fixture no longer compiles against a current engine.
Two things changed in the engine's listener API:
onChangeused to receive aStateStoreSupportand required aninitStore(store)call before the store field could be used. It now receives the resolvedStateStoredirectly — the store is event data, handed in alongside the values it belongs to, so there is no init ritual and no store field to hold.AbstractOnChangeListener→AbstractWindowListener, since it is window-specific and the old name collided withjava.awt.event.WindowListenerin auto-import-heavy editors.Fixture-only change; no library code touched.