Conversation
There was a problem hiding this comment.
Code Review
This pull request significantly expands and restructures the documentation regarding Ramble's pipelines and phases. It introduces a new pipelines.rst file detailing common workspace workflows, updates advanced_topics.rst with architectural overviews and phase graphs, integrates Graphviz diagrams to visualize these workflows, and updates Sphinx configuration settings. The review feedback suggests minor grammatical and phrasing corrections to improve readability, such as removing a redundant "below", correcting "usecases" to "use cases", and adding a missing article.
7432f6d to
3296c9a
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
Ramble Performance Test MetricsResults produced with commit: ec9fbef
|
Signed-off-by: Ti Leggett <tileggett@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ti Leggett <tileggett@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ti Leggett <tileggett@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ti Leggett <tileggett@google.com>
697a647 to
227410a
Compare
|
/gcbrun |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The Docker image won't get rebuilt based on the new Dockerfiles until the PR is merged, so the doc build test is still using the old image that doesn't have graphviz included. Verified that adding graphviz does allow the doc build test to complete. I can split the Dockerfile updates into their own PR to force an image rebuild and then have this one re-run the tests after that if that is more desirable. |
ec9fbef to
227410a
Compare
This:
conf.pyfor graphviz to remove global rank direction and sets the fonts to something less Mac specificAttaching PDFs of the new pages to make it a bit easier to see the results without people needing to checkout my branch and run Sphinx against it.
Basics - Pipelines and Phases.pdf
Advanced - Pipelines and Builtins.pdf