Add more type checking to Ramble - #1777
Draft
linsword13 wants to merge 1 commit into
Draft
linsword13 wants to merge 1 commit into
linsword13 wants to merge 1 commit into
Conversation
linsword13
force-pushed
the
more-type-checks
branch
from
September 10, 2026 19:16
e77e7e1 to
b90d1b4
Compare
Ramble Performance Test MetricsResults produced with commit: c6aa06f
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Lin Guo <linsword13@gmail.com>
linsword13
force-pushed
the
more-type-checks
branch
from
September 11, 2026 00:04
b90d1b4 to
c6aa06f
Compare
linsword13
marked this pull request as ready for review
September 11, 2026 00:40
rfbgo
reviewed
Sep 11, 2026
| if os.path.exists(candidate): | ||
| config_name = config | ||
| config_file = candidate | ||
| break |
Collaborator
There was a problem hiding this comment.
Is this early exit definitely desirable? I'm having a hard time thinking through it but it feels like it could change the precedence ?
| def draw(self, perf_measure, scale_var, series, pdf_report, y_label=None): | ||
| def draw(self, perf_measure, scale_var, series, *args, **kwargs): | ||
| pdf_report = args[0] if len(args) > 0 else kwargs.get("pdf_report") | ||
| y_label = args[1] if len(args) > 1 else kwargs.get("y_label", None) |
Collaborator
There was a problem hiding this comment.
This line gives me pause. Is it definitely the right to fix it? I don't have a concrete suggestion, but it makes me think like we have the wrong interface? I almost prefer this function is renamed if we aren't able to meet the parents api "contract" (over hiding the arg changes). What do you think ?
linsword13
marked this pull request as draft
September 11, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.