Skip to content

add spack retry to CI - #1785

Open
rfbgo wants to merge 3 commits into
Ramble-Project:developfrom
rfbgo:ci_spack_retry
Open

rfbgo wants to merge 3 commits into
Ramble-Project:developfrom
rfbgo:ci_spack_retry

Conversation

@rfbgo

@rfbgo rfbgo commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

This will help us be more resilient to GH flakiness by being able to retry:

Step #2 - "ramble-unit-tests": us-central1-docker.pkg.dev/ramble-eng/ramble-repo/ramble-rockylinux-8-spackv1.0.0-python3.7.17:latest
Step #2 - "ramble-unit-tests": branch 'develop' set up to track 'origin/develop'.
Step #2 - "ramble-unit-tests": fatal: unable to access 'https://github.com/spack/spack-packages.git/': Empty reply from server
Step #2 - "ramble-unit-tests": ==> Warning: Error constructing repository '/builder/home/.spack/package_repos/fncqgg4': Failed to clone repository builtin

It also DRYs the env setup into a shared script to

@rfbgo
rfbgo requested a review from linsword13 September 15, 2026 14:17
Signed-off-by: Bob <robertbird@google.com>
@ramble-project-pr-bot

ramble-project-pr-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 86a44be

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 1.0556 1.0590 (b7a264f) 1.0648
test_large_template_expansion passed 1.1993 1.1979 (b7a264f) 1.3086
test_many_experiments passed 24.1654 23.4773 (b7a264f) 24.0185
test_many_objects_defaults passed 12.5638 12.3728 (b7a264f) 12.4969
test_matrix_filter_perf passed 1.0854 1.0663 (b7a264f) 1.1014

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@@ -32,22 +32,7 @@ steps:
- '-c'
- |
set -e

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit outside the scope, but I wonder if this set -e would defeat the retry somehow?

@rfbgo rfbgo Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very good question. My first reaction when I saw this failure was "oh I'm surprised we don't have set -e? It should have saved me?". I think you're right here and set -e will defeat my intention in this specific yaml

I guess there is an implied choice here between "fail fast" (-e) and "retry and fail clearly". Any preference?

Comment thread share/ramble/cloud-build/setup-ci-env.sh Outdated
Signed-off-by: Bob <robertbird@google.com>
Signed-off-by: Bob <robertbird@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants