Conversation
Signed-off-by: Bob <robertbird@google.com>
rfbgo
force-pushed
the
ci_spack_retry
branch
from
September 15, 2026 14:18
21fe024 to
165d927
Compare
Ramble Performance Test MetricsResults produced with commit: 86a44be
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
linsword13
reviewed
Sep 16, 2026
| @@ -32,22 +32,7 @@ steps: | |||
| - '-c' | |||
| - | | |||
| set -e | |||
Collaborator
There was a problem hiding this comment.
A bit outside the scope, but I wonder if this set -e would defeat the retry somehow?
Collaborator
Author
There was a problem hiding this comment.
That is a very good question. My first reaction when I saw this failure was "oh I'm surprised we don't have set -e? It should have saved me?". I think you're right here and set -e will defeat my intention in this specific yaml
I guess there is an implied choice here between "fail fast" (-e) and "retry and fail clearly". Any preference?
Signed-off-by: Bob <robertbird@google.com>
rfbgo
force-pushed
the
ci_spack_retry
branch
from
September 17, 2026 13:12
215d94c to
b218d27
Compare
Signed-off-by: Bob <robertbird@google.com>
rfbgo
force-pushed
the
ci_spack_retry
branch
from
September 17, 2026 16:25
218f113 to
86a44be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help us be more resilient to GH flakiness by being able to retry:
It also DRYs the env setup into a shared script to