feat: wire missing mempool.space API calls into main CLI binary - #2
Draft
RandyMcMillan with Copilot wants to merge 1 commit into
Draft
RandyMcMillan with Copilot wants to merge 1 commit into
RandyMcMillan with Copilot wants to merge 1 commit into
Conversation
- Add --flag support in args.rs for all API calls that had standalone
binaries but were not accessible via the main mempool-space binary:
- Blocks: --block_feerates, --block_predictions, --block_rewards,
--block_sizes_and_weights
- Fees: --fees_mempool_blocks, --fees_recommended
- Mempool: --mempool, --mempool_txids, --mempool_full_rbf_transactions,
--mempool_rbf_transactions, --mempool_recent
- Transactions: --children_pay_for_parent, --transaction,
--transaction_hex, --transaction_merkle_block_proof,
--transaction_merkle_proof, --transaction_outspend (+ --outspend_index),
--transaction_outspends, --transaction_raw, --transaction_rbf_timeline,
--transaction_status, --transaction_times
- Lightning: all 22 lightning API endpoints
- Mining: --mining_hashrate, --mining_reward_stats,
--mining_blocks_timestamp
- Create missing src/bin/mempool-space_mempool_txids.rs binary
- Fix transaction_outspend.rs: wrong URL (/address/:address -> tx/:txid/outspend/:index)
- Fix transaction_outspends.rs: remove spurious api/ URL prefix
Co-authored-by: RandyMcMillan <152159+RandyMcMillan@users.noreply.github.com>
Copilot
AI
changed the title
feat: add missing mempool.space API call wiring
feat: wire missing mempool.space API calls into main CLI binary
Aug 14, 2026
Copilot created this pull request from a session on behalf of
RandyMcMillan
August 14, 2026 10:25
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
49 API endpoints had standalone
src/bin/mempool-space_*.rsbinaries but no--flagsupport in the mainmempool-spaceCLI, making them unreachable via the primary entry point.Added
--flagwiring inargs.rsEach entry gets an
optsdefinition,opt_present()dispatch block, struct field, and initializer.Blocks:
--block_feerates,--block_predictions,--block_rewards,--block_sizes_and_weightsFees:
--fees_mempool_blocks,--fees_recommendedMempool:
--mempool,--mempool_txids,--mempool_full_rbf_transactions,--mempool_rbf_transactions,--mempool_recentTransactions:
--children_pay_for_parent,--transaction,--transaction_hex,--transaction_merkle_block_proof,--transaction_merkle_proof,--transaction_outspend(+--outspend_index),--transaction_outspends,--transaction_raw,--transaction_rbf_timeline,--transaction_status,--transaction_timesLightning (22):
--lightning_channels,--lightning_channels_from_node_pubkey,--lightning_channels_from_txid,--lightning_channels_geo,--lightning_channels_geodata,--lightning_node_stats,--lightning_node_stats_per_country,--lightning_nodes,--lightning_nodes_channels,--lightning_nodes_in_country,--lightning_nodes_isp_ranking,--lightning_nodes_ranking,--lightning_nodes_ranking_age,--lightning_nodes_ranking_connectivity,--lightning_nodes_ranking_liquidity,--lightning_nodes_statistics,--lightning_nodes_stats_per_isp,--lightning_search,--lightning_statistics,--lightning_top_nodes_by_connectivity,--lightning_top_nodes_by_liquidity,--lightning_top_oldests_nodesMining:
--mining_hashrate <TIMEPERIOD>,--mining_reward_stats <COUNT>,--mining_blocks_timestamp <UTC_SECS>New binary
mempool-space_mempool_txids.rs—GET /api/mempool/txids, referenced in docs/tests but file was absent.Bug fixes in existing binaries
transaction_outspend.rs: was calling/address/:address; corrected totx/:txid/outspend/:index, now accepts txid + optional index (default0).transaction_outspends.rs: stripped spuriousapi/prefix (api/tx/…→tx/…).