Conversation
Member
Author
|
@rubo77 please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1112
Summary
Prevent filenames and diagnostics from emitting terminal control characters through standard output or standard error. The output filter now validates permitted UTF-8 sequences, preserves ordinary valid UTF-8 and escapes raw or UTF-8-encoded C1 controls. DEL and malformed sequences are also handled safely.
Generic output no longer treats leading or trailing carriage returns as trusted framing. The three intentional progress displays now emit their carriage return through a dedicated helper.
Compatibility
Strict UTF-8 decoding applies only where rsync already permits 8 bit output. Default byte-oriented filtering remains unchanged. This does not depend on locale charset detection. It therefore avoids the BSD and macOS locale concern from an earlier private implementation.