Modify corrected OpFlash to include particle and photon propagation time - #175
Open
asanchezcastillo wants to merge 2 commits into
Open
Modify corrected OpFlash to include particle and photon propagation time#175asanchezcastillo wants to merge 2 commits into
asanchezcastillo wants to merge 2 commits into
Conversation
asanchezcastillo
marked this pull request as draft
July 21, 2026 14:56
asanchezcastillo
marked this pull request as ready for review
July 29, 2026 14:30
PetrilloAtWork
requested changes
Aug 3, 2026
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
Please fix the checksums.
The rest is good.
Comment on lines
+318
to
+320
| <class name="sbn::CorrectedOpFlashTiming" ClassVersion="18"> | ||
| <version ClassVersion="18" checksum="1139303800"/> | ||
| <version ClassVersion="17" checksum="1139303800"/> |
Member
There was a problem hiding this comment.
A duplicate checksum is new to me. Anyway, only one checksum update per PR:
Suggested change
| <class name="sbn::CorrectedOpFlashTiming" ClassVersion="18"> | |
| <version ClassVersion="18" checksum="1139303800"/> | |
| <version ClassVersion="17" checksum="1139303800"/> | |
| <class name="sbn::CorrectedOpFlashTiming" ClassVersion="17"> | |
| <version ClassVersion="17" checksum="1139303800"/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the CorrectedOpFlashTiming object to include the photon time of flight and particle propagation time used during the correction of the op flash timing. These attributes are required for downstream correction. More information can be found here.
This PR should we merged with
SBNSoftware/sbndcode#946.
SBNSoftware/sbnanaobj#195
SBNSoftware/sbncode#666