Treat blank URL options as unset - #154
Merged
Merged
Conversation
bpapillon
marked this pull request as ready for review
July 28, 2026 00:20
cbrady
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat empty or whitespace-only
basePathandeventCaptureBaseURLas unset so the built-in defaults apply.Consumers often forward env vars straight through (
basePath: process.env.X), which is""when the var is present but empty. An empty string survives the downstream?? defaultand produces a broken base URL — e.g. event capture posting to"/batch"and silently dropping every batch. Normalizes in both theSchematicClientconstructor andEventCaptureClient.