[Math] try to simplify the axis permutation for riemann solvers - #2223
[Math] try to simplify the axis permutation for riemann solvers#2223tdavidcl wants to merge 2 commits into
Conversation
Copy the whole state and negate rhovel only if present (via a HasRhovel concept), instead of hardcoding rho/rhoe field access. This lets gas and dust conservative states share the same invert_axis implementation. Assisted-by: Claude Sonnet 5
… field Apply the same HasRhovel-guarded if constexpr pattern used for invert_axis to y_to_x, x_to_y, z_to_x, and x_to_z: copy the whole state and only permute rhovel components when present, instead of hardcoding rho/rhoe. Assisted-by: Claude Sonnet 5
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Workflow reportworkflow report corresponding to commit acbca35 Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
|
@claude review this PR and post the review as a GitHub comment here |
No description provided.