Skip to content

[Math] try to simplify the axis permutation for riemann solvers - #2223

Draft
tdavidcl wants to merge 2 commits into
Shamrock-code:mainfrom
tdavidcl:riemann_solver_generalisation
Draft

[Math] try to simplify the axis permutation for riemann solvers#2223
tdavidcl wants to merge 2 commits into
Shamrock-code:mainfrom
tdavidcl:riemann_solver_generalisation

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

No description provided.

Copy the whole state and negate rhovel only if present (via a HasRhovel
concept), instead of hardcoding rho/rhoe field access. This lets gas and
dust conservative states share the same invert_axis implementation.

Assisted-by: Claude Sonnet 5
… field

Apply the same HasRhovel-guarded if constexpr pattern used for invert_axis
to y_to_x, x_to_y, z_to_x, and x_to_z: copy the whole state and only
permute rhovel components when present, instead of hardcoding rho/rhoe.

Assisted-by: Claude Sonnet 5
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label profile-build to run the compile-time build profile job even in light CI.
6 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit acbca35
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 5
New warnings : 5
Warnings count : 8222 → 8222 (0.0%)

Detailed changes :
- src/shammath/include/shammath/riemann_common.hpp:175: warning: Member y_to_x(const Tcons c) (function) of namespace shammath is not documented.
+ src/shammath/include/shammath/riemann_common.hpp:178: warning: Member y_to_x(const Tcons c) (function) of namespace shammath is not documented.
- src/shammath/include/shammath/riemann_common.hpp:186: warning: Member x_to_y(const Tcons c) (function) of namespace shammath is not documented.
+ src/shammath/include/shammath/riemann_common.hpp:189: warning: Member x_to_y(const Tcons c) (function) of namespace shammath is not documented.
- src/shammath/include/shammath/riemann_common.hpp:197: warning: Member z_to_x(const Tcons c) (function) of namespace shammath is not documented.
+ src/shammath/include/shammath/riemann_common.hpp:200: warning: Member z_to_x(const Tcons c) (function) of namespace shammath is not documented.
- src/shammath/include/shammath/riemann_common.hpp:208: warning: Member x_to_z(const Tcons c) (function) of namespace shammath is not documented.
+ src/shammath/include/shammath/riemann_common.hpp:211: warning: Member x_to_z(const Tcons c) (function) of namespace shammath is not documented.
- src/shammath/include/shammath/riemann_common.hpp:219: warning: Member invert_axis(const Tcons c) (function) of namespace shammath is not documented.
+ src/shammath/include/shammath/riemann_common.hpp:222: warning: Member invert_axis(const Tcons c) (function) of namespace shammath is not documented.

@tdavidcl tdavidcl changed the title [Math] try to displify the axis permutation for riemann solvers [Math] try to simplify the axis permutation for riemann solvers Aug 31, 2026
@tdavidcl

tdavidcl commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@claude review this PR and post the review as a GitHub comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant