Add settings.gradle.kts; bump PalantirJavaFormat, ToolBase; extend JacksonV2 - #750
Merged
Conversation
This repository had no settings file, so Gradle derived the root project name
from the directory and searched parent directories for one. Checking `config`
out as a submodule of a superproject that has its own settings file -- such as
`SpineEventEngine/summit` -- made Gradle bind this directory to that build:
Project directory '.../summit/config' is not part of the build defined by
settings file '.../summit/settings.gradle.kts'.
CI was unaffected, since it checks the repository out standalone, but the build
could not be run from inside such a superproject.
`rootProject.name` repeats the name Gradle previously derived, so nothing else
about the build changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* `PalantirJavaFormat` 2.91.0 -> 2.97.0, the current release on Maven Central. The `compiler` repository had already bumped to 2.97.0 locally, so `./config/pull` was rolling that value backward there. * `ToolBase` 2.0.0-SNAPSHOT.420 -> .421, published by tool-base#190. Consumer repositories migrating off the retired `tool-base` artifact need `.421`, and had to re-pin it by hand after every pull while this repository still shipped `.420`. `dogfoodingVersion` stays at `.410`, and the KDoc on `ToolBase.lib` keeps naming `.420` -- that records when the artifact stopped being published, which does not change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…onV2` The IntelliJ Platform brings both artifacts on the Jackson 2.x line, and they clash with the versions the project resolves. `JacksonV2` declared neither, so consumers had to force them through string literals repeating the coordinates at every call site. * `JacksonV2.Junior.objects` mirrors `Jackson.Junior.objects` on the 2.x line. * `JacksonV2.Module.kotlin` mirrors `Jackson.moduleKotlin`. Both are added to their objects' `modules`, so `artifacts`, `artifact(module)`, and `forceArtifacts(...)` pick them up and callers get the version applied for them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
alexander-yevsyukov
changed the title
settings.gradle.ktssettings.gradle.kts; bump PalantirJavaFormat, ToolBase; extend JacksonV2
armiol
approved these changes
Aug 19, 2026
alexander-yevsyukov
added a commit
to SpineEventEngine/core-jvm-compiler
that referenced
this pull request
Aug 19, 2026
`jackson-jr-objects` and the 2.x `jackson-module-kotlin` come only from the IntelliJ Platform, yet still clash with the versions we resolve. `JacksonV2` declared neither, so both coordinates were repeated as string literals at five call sites, each interpolating the version by hand. `config` now declares them as `JacksonV2.Junior.objects` and `JacksonV2.Module.kotlin` (SpineEventEngine/config#750). Take the updated `JacksonV2` and use it: * Where the surrounding code already calls `JacksonV2.Module.forceArtifacts`, `jackson-module-kotlin` is covered by that call now that it belongs to `Module.modules`, and `Junior.forceArtifacts` covers `jackson-jr-objects`. * In the one block that forces no other Jackson object, both coordinates come from `artifact(module)`, which applies the version. Also refresh the `pomProvidedModules` doc, which explained why `JacksonV2` declared neither artifact. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Add
settings.gradle.ktsThis repository had no settings file, so Gradle derived the root project name from
the directory and kept searching parent directories for one. Checking
configout asa submodule of a superproject that has its own settings file — such as
SpineEventEngine/summit— made Gradlebind this directory to that build and refuse to run:
CI never saw this, because it checks the repository out standalone. But the build
could not be run at all from inside such a superproject, which is how the SDK
repositories are worked on together.
rootProject.namerepeats the name Gradle previously derived from the projectdirectory, so nothing else about the build changes.
configwas the only Spine SDKrepository without a settings file of its own.
2. Bump
PalantirJavaFormat->2.97.0Was
2.91.0;2.97.0is the current<latest>/<release>on Maven Central.The
compilerrepository had already bumped to2.97.0locally, which meant./config/pullwas silently rolling that value backward there. This removesthe cause.
3. Bump
ToolBase->2.0.0-SNAPSHOT.421Was
2.0.0-SNAPSHOT.420..421is published bytool-base#190.
Consumer repositories migrating off the retired
tool-baseartifact need.421,and had to re-pin it by hand after every
./config/pullwhile this repository stillshipped
.420.dogfoodingVersionstays at.410. The KDoc onToolBase.libkeeps naming.420— that records when the artifact stopped being published, which does not change.
4. Declare
jackson-jr-objectsandjackson-module-kotlinunderJacksonV2The IntelliJ Platform brings both artifacts on the Jackson 2.x line, and they clash
with the versions projects resolve.
JacksonV2declared neither, so consumers had toforce them through string literals repeating the coordinates at every call site
(five of them in
core-jvm-compileralone).JacksonV2.Junior.objectsmirrorsJackson.Junior.objectson the 2.x line.JacksonV2.Module.kotlinmirrorsJackson.moduleKotlin.Both are added to their objects'
modules, soartifacts,artifact(module), andforceArtifacts(...)pick them up and callers get the version applied for theminstead of interpolating it.
Verification
Run from inside a superproject whose own
settings.gradle.ktsis present — the exactcondition that used to fail:
./gradlew clean detekt— BUILD SUCCESSFUL (this repo's CI command)./gradlew projects—Root project 'config', unchangedbuildSrcbuild— BUILD SUCCESSFUL,:testand:checkexecuted🤖 Generated with Claude Code