Restore canary quality tools and support tagged release baselines - #35
Merged
Merged
Conversation
brianvarskonst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency canaries update with Composer scripts and plugins disabled. Packages using named PHPCS standards therefore lost the registration normally supplied by the Composer installer plugin, causing the first Theme Starter canary to fail.
Register installed PHPCS standards and PHPStan extensions explicitly during QA, after removing installation credentials. Composer updates continue with
--no-scripts --no-plugins. This also restores WordPress-aware analysis: an invalid hook previously passed without registered extensions and now fails as expected.Allow DDEV callers to select a tagged release set through optional
checkout_ref; the default retains the normal event checkout. Starter and Demo scheduled update canaries can therefore begin with their tagged lockfiles.Validation: the actual QA shell against a fresh pluginless Theme installation passes all gates, including PHPCS, PHPStan with three extensions, five PHPUnit tests and 36 template assertions. The negative WordPress hook fixture fails as expected. All workflow contracts, actionlint, audits and 55 Bash/PHP fixtures pass; the hosted Theme Starter canary will be repeated with this revision.