Show heartbeat origin IP on recent events - #41
Merged
Conversation
Store the client address on received pings so check timelines can show where a heartbeat came from, without inventing IPs for missed heartbeats or probes.
Cast Jest objectContaining matchers to object so CI eslint no longer treats the ping service spec as an unsafe any assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Heartbeat
Upevents now store and display the client origin IP on Recent events. Missed-heartbeatDownrows and HTTP/TCP probes stay without an IP.The API trusts the reverse-proxy hop so production records the real client, not Traefik.
Validation
.envfiles are includedChecklist
Test plan
Uprow shows the origin IPDownrows still have no IP