Fixes and improvements

[KenVanHoeylandt]

Summary by CodeRabbit

• New Features
  • USB keyboards are detected and connected dynamically, with improved LVGL input support.
  • Apps can specify compatible device IDs, helping ensure device-specific apps appear only where supported.
  • App Hub restores its scroll position and filters apps appropriately on supported devices.
• Bug Fixes
  • Improved hardware and software keyboard availability detection.
  • Standardized application and service identifiers across devices.
  • Updated application data storage paths for more consistent settings and user data handling.
• Documentation
  • Clarified audio codec integration guidance and licensing information.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change adds the TactilityKernelCpp build target and a C++ allocator wrapper. It renames many app, service, launcher, and auto-start IDs to tactility.* across manifests, device properties, and defaults. It changes app user-data paths to root/user/app/<app_id> and updates several settings path call sites. It adds requires.device.id parsing to app metadata. It adds runtime USB keyboard child devices, a DEVICE_EVENT_STOPPING event, and LVGL keyboard device listening. It also updates AppHub state handling, keyboard availability checks, USB input allocation cleanup, and related documentation.

Merge Risk: 🟠 High · up to 4c53a

The PR changes USB keyboard lifecycle handling, App Hub refresh behavior, app compatibility checks, and persistent storage locations. At the current head, asynchronous callbacks may still access destroyed resources, incompatible apps may launch, and existing settings may be ignored after migration, creating crash, incorrect-runtime, and data-loss risks; the PR is not merge-ready until these issues are addressed.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 21.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is generic and does not identify the primary changes, which include namespaced app IDs, keyboard support, and TactilityKernelCpp integration.	Replace the title with a specific summary, such as "Namespace app IDs and add USB keyboard support".

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 12

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d5f846e-4eef-43f6-8323-81a3e24b40dd

📥 Commits

Reviewing files that changed from the base of the PR and between f943c4d and 4c53a84.

📒 Files selected for processing (140)

• CMakeLists.txt
• Devices/btt-panda-touch/device.properties
• Devices/cl32/device.properties
• Devices/cyd-2432s024c/device.properties
• Devices/cyd-2432s024r/device.properties
• Devices/cyd-2432s028r/device.properties
• Devices/cyd-2432s028rv3/device.properties
• Devices/cyd-2432s032c/device.properties
• Devices/cyd-3248s035c/device.properties
• Devices/cyd-4848s040c/device.properties
• Devices/cyd-8048s043c/device.properties
• Devices/cyd-e32r28t/device.properties
• Devices/cyd-e32r32p/device.properties
• Devices/elecrow-crowpanel-advance-28/device.properties
• Devices/elecrow-crowpanel-advance-35/device.properties
• Devices/elecrow-crowpanel-advance-50/device.properties
• Devices/elecrow-crowpanel-basic-28/device.properties
• Devices/elecrow-crowpanel-basic-35/device.properties
• Devices/elecrow-crowpanel-basic-50/device.properties
• Devices/es3c28p/device.properties
• Devices/generic-esp32/device.properties
• Devices/generic-esp32c6/device.properties
• Devices/generic-esp32p4/device.properties
• Devices/generic-esp32s3/device.properties
• Devices/guition-jc1060p470ciwy/device.properties
• Devices/guition-jc2432w328c/device.properties
• Devices/guition-jc8048w550c/device.properties
• Devices/heltec-wifi-lora-32-v3/device.properties
• Devices/lilygo-tdeck-max/device.properties
• Devices/lilygo-tdeck-plus/device.properties
• Devices/lilygo-tdeck-pro/device.properties
• Devices/lilygo-tdeck/device.properties
• Devices/lilygo-tdisplay-s3/device.properties
• Devices/lilygo-tdisplay/device.properties
• Devices/lilygo-tdongle-s3/device.properties
• Devices/lilygo-thmi/device.properties
• Devices/lilygo-tlora-pager/device.properties
• Devices/m5stack-cardputer-adv/device.properties
• Devices/m5stack-cardputer/device.properties
• Devices/m5stack-core2/device.properties
• Devices/m5stack-cores3/device.properties
• Devices/m5stack-papers3/device.properties
• Devices/m5stack-stackchan/device.properties
• Devices/m5stack-stickc-plus2/device.properties
• Devices/m5stack-sticks3/device.properties
• Devices/m5stack-tab5/device.properties
• Devices/simulator/device.properties
• Devices/tulip-4r11/device.properties
• Devices/unphone/device.properties
• Devices/waveshare-esp32-s3-geek/device.properties
• Devices/waveshare-s3-lcd-13/device.properties
• Devices/waveshare-s3-touch-lcd-128/device.properties
• Devices/waveshare-s3-touch-lcd-147/device.properties
• Devices/waveshare-s3-touch-lcd-43/device.properties
• Devices/wireless-tag-wt32-sc01-plus/device.properties
• Drivers/audio-codec-module/README.md
• Firmware/Kconfig
• Modules/app-module/include/app/metadata.h
• Modules/app-module/private/app/private/app_metadata_parsing_internal.h
• Modules/app-module/source/app_metadata_parsing.cpp
• Modules/app-module/source/app_metadata_parsing_v2.cpp
• Modules/app-module/source/app_paths.cpp
• Modules/gps-module/source/gps_settings.cpp
• Modules/lvgl-module/source/devices/keyboard.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usb_device_controller.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
• Platforms/platform-esp32/source/module.cpp
• Tactility/CMakeLists.txt
• Tactility/Include/Tactility/lvgl/KeyboardDeviceListener.h
• Tactility/Private/Tactility/app/apphub/AppHubEntry.h
• Tactility/Source/Tactility.cpp
• Tactility/Source/app/addgps/AddGps.cpp
• Tactility/Source/app/alertdialog/AlertDialog.cpp
• Tactility/Source/app/appdetails/AppDetails.cpp
• Tactility/Source/app/apphub/AppHubApp.cpp
• Tactility/Source/app/apphub/AppHubEntry.cpp
• Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
• Tactility/Source/app/applist/AppList.cpp
• Tactility/Source/app/appsettings/AppSettings.cpp
• Tactility/Source/app/apwebserver/ApWebServer.cpp
• Tactility/Source/app/audiosettings/AudioSettings.cpp
• Tactility/Source/app/boot/Boot.cpp
• Tactility/Source/app/btmanage/BtManage.cpp
• Tactility/Source/app/btpeersettings/BtPeerSettings.cpp
• Tactility/Source/app/chat/ChatApp.cpp
• Tactility/Source/app/chat/ChatSettings.cpp
• Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp
• Tactility/Source/app/development/Development.cpp
• Tactility/Source/app/files/FilesApp.cpp
• Tactility/Source/app/fileselection/FileSelection.cpp
• Tactility/Source/app/gpssettings/GpsSettings.cpp
• Tactility/Source/app/grovesettings/GroveSettings.cpp
• Tactility/Source/app/i2cscanner/I2cScanner.cpp
• Tactility/Source/app/imageviewer/ImageViewer.cpp
• Tactility/Source/app/inputdialog/InputDialog.cpp
• Tactility/Source/app/kerneldisplay/KernelDisplay.cpp
• Tactility/Source/app/keyboard/KeyboardSettings.cpp
• Tactility/Source/app/launcher/Launcher.cpp
• Tactility/Source/app/localesettings/LocaleSettings.cpp
• Tactility/Source/app/notes/Notes.cpp
• Tactility/Source/app/power/Power.cpp
• Tactility/Source/app/poweroff/PowerOff.cpp
• Tactility/Source/app/screenshot/Screenshot.cpp
• Tactility/Source/app/selectiondialog/SelectionDialog.cpp
• Tactility/Source/app/settings/Settings.cpp
• Tactility/Source/app/setup/Setup.cpp
• Tactility/Source/app/systeminfo/SystemInfo.cpp
• Tactility/Source/app/timedatesettings/TimeDateSettings.cpp
• Tactility/Source/app/timezone/TimeZone.cpp
• Tactility/Source/app/touchcalibration/TouchCalibration.cpp
• Tactility/Source/app/trackball/TrackballSettings.cpp
• Tactility/Source/app/usbsettings/UsbSettings.cpp
• Tactility/Source/app/webserversettings/WebServerSettings.cpp
• Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
• Tactility/Source/app/wificonnect/WifiConnect.cpp
• Tactility/Source/app/wifimanage/WifiManage.cpp
• Tactility/Source/lvgl/KeyboardDeviceListener.cpp
• Tactility/Source/lvgl/UsbHidInput.cpp
• Tactility/Source/service/audio/AudioService.cpp
• Tactility/Source/service/development/DevelopmentService.cpp
• Tactility/Source/service/development/DevelopmentSettings.cpp
• Tactility/Source/service/displayidle/DisplayIdle.cpp
• Tactility/Source/service/espnow/EspNowService.cpp
• Tactility/Source/service/keyboardidle/KeyboardIdle.cpp
• Tactility/Source/service/memorychecker/MemoryCheckerService.cpp
• Tactility/Source/service/rtctime/RtcTimeService.cpp
• Tactility/Source/service/screenshot/Screenshot.cpp
• Tactility/Source/service/statusbar/Statusbar.cpp
• Tactility/Source/service/webserver/WebServerService.cpp
• Tactility/Source/service/wifi/Wifi.cpp
• Tactility/Source/settings/DisplaySettings.cpp
• Tactility/Source/settings/TrackballSettings.cpp
• Tactility/Source/settings/WebServerSettings.cpp
• TactilityFreeRtos/README.md
• TactilityKernel/include/tactility/device_listener.h
• TactilityKernel/source/device.cpp
• TactilityKernelCpp/CMakeLists.txt
• TactilityKernelCpp/Include/TactilityCpp/Allocator.h
• TactilityKernelCpp/LICENSE-Apache-2.0.md
• TactilityKernelCpp/README.md

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.