fix(QTDI-3531): Fix uispec goal failure by undx · Pull Request #1286 · Talend/component-runtime

undx · 2026-10-05T14:34:59Z

Requirements

Any code change adding any logic MUST be tested through a unit test executed with the default build
Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

Jira: QTDI-3531 — talend-component:uispec fails, for two independent reasons:

VerifyError when run on a connectors repo. The plugin classloader realm contains the plugin dependencies plus the transitive dependencies of every connector CAR (844 jars in connectors). It includes cxf-rt-transports-http:4.1.8 (jakarta servlet) ahead of 3.6.12 (javax servlet) that component-server needs, so ServiceListGeneratorServlet is a jakarta servlet where a javax one is expected.
NullPointerException in StaticResourceGenerator.route(...). The /api/v1/cache/clear route (QTDI-1188) is built with null content, so content.getBytes(...) fails even with a clean classpath. Nothing tested uispec, so it went unnoticed.

What does this PR adds (design/code thoughts)?

StaticResourceGenerator.route(...) is null-safe (null content → empty body) + unit test StaticResourceGeneratorTest.
UiSpecGeneratorMojo runs StaticUiSpecGenerator in an isolated URLClassLoader (parent = platform loader, TCCL set and restored, loader closed). Its classpath is the Aether-resolved graph of the plugin's own component-tools-webapp + component-runtime-beam + openwebbeans-se, so it no longer depends on CAR transitives in the plugin realm. Versions come from a filtered uispec-generator.properties.
New invoker IT src/it/uispec: builds a CAR dependency plus a conflicting cxf-rt-transports-http:4.1.8 plugin dependency, runs prepare-repository + uispec, and asserts uispec.zip contains component/ and configuration/ entries.
talend-component-maven-plugin/pom.xml: resource filtering for the properties file and openwebbeans-se declaration.

Validation: unit tests, RAT/checkstyle/spotless and invoker IT uispec green; talend-component:uispec validated manually in connectors/cloud/cloud-components-docker (-PPUSH_DOCKER, local SNAPSHOT) producing uispec.zip.

Out of scope: changing connectors' POMs, the web goal, other mojos' classloader strategy.

AI contribution metrics

Code Generation % (this PR): 100% (309/309 changed lines)
Code Generation % (ticket-wide cumulative): 100%
Technical Design % (ticket-wide cumulative): 100%

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

this PR has been written with the help of GitHub Copilot or another generative AI tool

Run the static UI spec generator in an isolated classloader built from the plugin's own component-tools-webapp graph, so transitive dependencies of connector CARs (e.g. CXF 4 / jakarta servlet) no longer shadow the ones component-server needs and trigger a VerifyError. Make StaticResourceGenerator.route null-safe so the /api/v1/cache/clear route no longer fails with a NullPointerException. Add a unit test and an invoker IT guarding the uispec goal. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

undx · 2026-10-05T14:35:11Z

Scope & Design Review

Critic Round 1 — Findings

#	Severity	File	Description	Suggested Fix
1	MINOR	talend-component-maven-plugin/pom.xml	`component-tools-webapp` is no longer imported by the Mojo but stays a plugin dependency; kept on purpose so the reactor builds/installs it first and the isolated resolution finds the SNAPSHOT.	None (documented here).
2	MINOR	UiSpecGeneratorMojo	Isolated classpath is resolved with the plugin version for `component-tools-webapp`/`component-runtime-beam` — assumes lock-step versions (true for this reactor/releases).	None.
3	MINOR	StaticResourceGeneratorTest	Uses JUnit assertions (module convention) rather than AssertJ.	Optional.

Checked: null-safety of route, TCCL restored in finally, loader closed (try-with-resources), generator exceptions propagate unchanged, version resource lookup (package-relative) and Maven filtering, offline/SNAPSHOT resolution through the build session, threadSafe mojo (per-invocation loader, per-thread TCCL), IT reproduces the realm pollution (CXF 4.1.8 plugin dependency) and asserts zip content.

Approval gate: APPROVED — no Blocker or Major findings. 3 Minor noted (non-blocking).

Signed: Claude Sonnet 5.5

undx · 2026-10-05T14:35:12Z

Compliance Report

Files reviewed (7): StaticResourceGenerator.java, StaticResourceGeneratorTest.java, UiSpecGeneratorMojo.java, talend-component-maven-plugin/pom.xml, uispec-generator.properties, src/it/uispec/pom.xml, src/it/uispec/postbuild.groovy.

File	Severity	Finding	Rule
StaticResourceGeneratorTest.java	ℹ️ Info	JUnit assertions instead of AssertJ (matches module convention)	Testing
talend-component-maven-plugin/pom.xml	ℹ️ Info	Resources filtering only for the properties file; no new dependency/CVE surface (libs resolved at runtime from existing managed versions)	Dependencies
Working tree	ℹ️ Info	Untracked AGENTS.md, CLAUDE.md, CONTEXT-MAP.md, docs/agents/* are unrelated to QTDI-3531 — must NOT be included in the PR	Scope discipline

No wildcard imports, try-with-resources used, specific exceptions with cause preserved, Apache headers present, Spotless/RAT/checkstyle green (step 5).

Critical fixed: 0, Warnings: 0, Info: 3

Signed: Claude Sonnet 5.5

…tion knowledge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…erver Maven 3.10+ rejects duplicate <plugin> declarations for the same groupId/artifactId at POM validation, breaking `mvn -pl <module> -am` and whole-reactor builds that include component-starter-server. The plugin was split into two <plugin> blocks (one carrying <dependencies>, the other <executions>) with identical <configuration>; merge them into a single declaration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The uispec invoker IT's .mvn/jvm.config only opened java.net, java.lang and java.util, missing java.lang.invoke (and others). On JDK 17+ this makes the embedded Meecrowave/Tomcat + CDI server fail at startup with InaccessibleObjectException on MethodHandles$Lookup, failing the IT both locally and on Jenkins CI. Complete the set to match the --add-opens list already used by the root pom's java9 profile. Note: .mvn/ directories are not tracked anywhere else in this repo and are commonly excluded by global gitignore templates; this file was force-added since the invoker plugin requires it to configure the forked build's JVM. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Critical Maven wrapper and dependency-resolution issues remain, and new UiSpec logic lacks default-build unit coverage.

Review effort: Lite
Findings: 2 · 1 · 1

Open (4)

Execution block is detached from the gmavenplus plugin · New
Dependency resolver uses plugin repositories instead of project repositories · New
New classloader logic lacks a default-build unit test · New
Documented IT command omits the required ci-build profile · New

What changed in this PR

Fixes talend:uispec classpath conflicts and null-content generation failures.

Changes:

Isolates UiSpec generator dependencies with a dedicated classloader.
Makes static routes null-safe with unit coverage.
Adds integration coverage, filtered dependencies, and documentation updates.

File	Summary
`talend-component-maven-plugin/src/main/resources/org/talend/sdk/component/maven/uispec-generator.properties`	Defines filtered generator dependency versions.
`talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/UiSpecGeneratorMojo.java`	Implements isolated generator loading and dependency resolution.
`talend-component-maven-plugin/src/it/uispec/postbuild.groovy`	Validates generated UiSpec archive contents.
`talend-component-maven-plugin/src/it/uispec/pom.xml`	Adds conflicting dependency integration-test setup.
`talend-component-maven-plugin/src/it/uispec/.mvn/jvm.config`	Configures required JVM module access.
`talend-component-maven-plugin/pom.xml`	Configures resource filtering and generator dependencies.
`repository-knowledge.md`	Documents UiSpec verification guidance.
`component-tools-webapp/src/test/java/org/talend/sdk/component/tools/webapp/standalone/generator/StaticResourceGeneratorTest.java`	Tests null and UTF-8 route content.
`component-tools-webapp/src/main/java/org/talend/sdk/component/tools/webapp/standalone/generator/StaticResourceGenerator.java`	Handles null route content safely.
`component-starter-server/pom.xml`	Alters Maven wrapper generation configuration; execution binding requires correction.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Resolve the generator classpath from the project repositories (the webapp, Beam and OpenWebBeans are regular dependencies, not plugins), extract the isolated run into a package-private method and add default build unit tests for the classloader isolation, TCCL restoration and error wrapping. Document the -Pci-build invoker command. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

undx · 2026-10-05T16:04:40Z

Review round 1 — summary

Comment	Class	Action
#1 — gmavenplus execution detached (`component-starter-server/pom.xml`)	Already addressed	Replied, see `1860795f4cf3`
#2 — resolver uses plugin repositories	Code fix	Fixed in `0bf42b04ef1d`
#3 — no default-build unit test for classloader logic	Code fix	Fixed in `0bf42b04ef1d` (`UiSpecGeneratorMojoTest`, 6 tests pass)
#4 — IT command omits `-Pci-build`	Code fix (doc)	Fixed in `0bf42b04ef1d`
Sonar — coverage on new code < 80%	Code fix (covered by #3)	New unit tests pushed; Aether resolution in `isolatedClasspath()` stays covered by the invoker IT only. Gate result to be checked after CI.

Fixes pushed: 0bf42b04ef1d — fix(QTDI-3531): Address review round 1 on uispec mojo
Pending clarifications: 0
Rebase: none (base not moved)

Round summary generated by AI. Please resolve threads after verifying the fixes.

Signed: GitHub Copilot

Copilot

Copilot review overview

🟡 Changes recommended

The isolated classloader omits required runtime dependencies, potentially causing NoClassDefFoundError during CDI startup.

Review effort: Lite
Findings: 1

Open (1)

Add missing runtime dependencies to prevent CDI startup NoClassDefFoundError · New

Resolved since last review (4)

Dependency resolver uses plugin repositories instead of project repositories
Execution block is detached from the gmavenplus plugin
New classloader logic lacks a default-build unit test
Documented IT command omits the required ci-build profile

Extract the classpath resolution into a package-private static method and cover it with unit tests using a stubbed RepositorySystem. Hoist the arguments out of the assertThrows lambdas (java:S5778). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

undx · 2026-10-05T16:50:21Z

Review round 2 — summary

Comment	Class	Action
Copilot — `UiSpecGeneratorMojo.java` "isolated graph omits `component-runtime-manager` / `component-runtime-design-extension`"	Already addressed (false positive)	Replied: both are transitive `compile` deps of `component-tools-webapp` (via `component-server`); the `uispec` invoker IT passes
Sonar `java:S5778` — `UiSpecGeneratorMojoTest` `assertThrows` lambdas	Code fix	Fixed in `52215f2` — arguments hoisted out of the 4 lambdas, assertions unchanged
Sonar Quality Gate — coverage on new code (44%)	Code fix	Fixed in `52215f2` — classpath resolution extracted into package-private `resolveClasspath(...)` (no behaviour change) and covered by 3 new tests with a stubbed `RepositorySystem` (roots/scope/repositories, URL conversion, failure wrapping)

Fixes pushed: 52215f2 — fix(QTDI-3531): Address review round 2 on uispec mojo
Pending clarifications: 0
Rebase: not needed (origin/master not ahead)

Round summary generated by AI. Please resolve threads after verifying the fixes. The Sonar gate result will be known once CI re-analyses this push.

Signed: Claude Opus 4.8

sonar-rnd · 2026-10-05T17:16:08Z

Quality Gate failed

78.00% Coverage on New Code (is less than 80.00%)
1 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Copilot

Copilot review overview

🟢 Approval recommended

All reviewed changes are covered by tests, and no unresolved blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

Add missing runtime dependencies to prevent CDI startup NoClassDefFoundError

undx and others added 3 commits October 5, 2026 16:45

docs(QTDI-3531): record uispec isolated classloader and manual valida…

2e492f6

…tion knowledge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

undx requested a lite review from Copilot October 5, 2026 15:41

Copilot started reviewing on behalf of undx October 5, 2026 15:41 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

undx requested a lite review from Copilot October 5, 2026 16:32

Copilot started reviewing on behalf of undx October 5, 2026 16:33 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread ...component-maven-plugin/src/main/java/org/talend/sdk/component/maven/UiSpecGeneratorMojo.java

undx requested a lite review from Copilot October 5, 2026 17:20

Copilot started reviewing on behalf of undx October 5, 2026 17:20 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Navigation Menu

fix(QTDI-3531): Fix uispec goal failure - #1286

fix(QTDI-3531): Fix uispec goal failure#1286
undx wants to merge 6 commits into
masterfrom
undx/QTDI-3531_fix_uispec_goal_failure

undx commented Oct 5, 2026 •

edited by atlassian Bot

Loading

Uh oh!

undx commented Oct 5, 2026

Uh oh!

undx commented Oct 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

undx commented Oct 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

undx commented Oct 5, 2026

Uh oh!

sonar-rnd Bot commented Oct 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

undx commented Oct 5, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements

Why this PR is needed?

What does this PR adds (design/code thoughts)?

AI contribution metrics

AI generated code

Uh oh!

undx commented Oct 5, 2026

Scope & Design Review

Critic Round 1 — Findings

Uh oh!

undx commented Oct 5, 2026

Compliance Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

undx commented Oct 5, 2026

Review round 1 — summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

undx commented Oct 5, 2026

Review round 2 — summary

Uh oh!

sonar-rnd Bot commented Oct 5, 2026

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

undx commented Oct 5, 2026 •

edited by atlassian Bot

Loading