It seems that Tandoor always accepts login requests from social accounts, even when the e-mail address is not yet verified there.
According to https://docs.allauth.org/en/latest/socialaccount/configuration.html the value of ACCOUNT_EMAIL_VERIFICATION would be used per default, but SOCIALACCOUNT_EMAIL_VERIFICATION is hardcoded set to 'none' here:
|
SOCIALACCOUNT_EMAIL_VERIFICATION = 'none' |
Is there a reason why this is hardcoded here?
Why not removing this value at all in favour of the default value (i.e. derived from ACCOUNT_EMAIL_VERIFICATION) or using the environment variable as for the other settings?
SOCIALACCOUNT_EMAIL_VERIFICATION = os.getenv('SOCIALACCOUNT_EMAIL_VERIFICATION', 'none')
It seems that Tandoor always accepts login requests from social accounts, even when the e-mail address is not yet verified there.
According to https://docs.allauth.org/en/latest/socialaccount/configuration.html the value of
ACCOUNT_EMAIL_VERIFICATIONwould be used per default, butSOCIALACCOUNT_EMAIL_VERIFICATIONis hardcoded set to 'none' here:recipes/recipes/settings.py
Line 248 in 4759ecf
Is there a reason why this is hardcoded here?
Why not removing this value at all in favour of the default value (i.e. derived from
ACCOUNT_EMAIL_VERIFICATION) or using the environment variable as for the other settings?